CollectionView Items display issue when Header is resized on iOS by kubaflo · Pull Request #21812 · dotnet/maui

kubaflo · 2024-04-13T15:23:59Z

Issues Fixed

Fixes #20538
Fixes #12429

Before	After
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-04-13.at.17.21.10.mp4	Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-04-13.at.17.17.05.mp4

src/Controls/src/Core/Handlers/Items/iOS/StructuredItemsViewController.cs

rmarinho · 2024-04-20T09:47:43Z

/azp run

azure-pipelines · 2024-04-20T09:48:02Z

Azure Pipelines successfully started running 3 pipeline(s).

rmarinho · 2024-04-22T13:24:42Z

/azp run

azure-pipelines · 2024-04-22T13:25:03Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2024-05-09T11:48:07Z

/azp run

azure-pipelines · 2024-05-09T11:48:28Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2024-06-10T14:13:10Z

/azp run

azure-pipelines · 2024-06-10T14:13:31Z

Azure Pipelines successfully started running 3 pipeline(s).

src/Core/src/Platform/iOS/MauiView.cs

mattleibow

I am just wondering about the fact that now we have 2 events that are triggering the layout code when the first did not work. Is there a reason for both?

mattleibow · 2024-07-18T19:02:20Z

src/Controls/src/Core/Handlers/Items/iOS/StructuredItemsViewController.cs

+				if (_headerUIView is MauiView hv)
+				{
+					hv.LayoutChanged -= HeaderViewLayoutChanged;
+				}


If we are now watching the actual method that is doing layout, do we still need the original _footerViewFormsElement.MeasureInvalidated? The code seems to end up calling the same HandleFormsElementMeasureInvalidated method.

IS grabbing the element for footer and header not the all view right? some still need for each one .

mattleibow · 2024-07-18T19:05:42Z

src/Core/src/Platform/iOS/MauiView.cs

 			}

 			CrossPlatformArrange(bounds);
+			OnLayoutChanged();


Maybe this should be renamed to match the method. Also, no need to have the method, just invoke the event directly. Maybe use a name of ArrangingSubviews or even just OnLayoutSubviews since it is internal. I see MovedToWindow got away with the same name because it was an explicit interface member.

I changed it to invoke the event directly

PureWeen

We should revisit if this is needed once we test on net9 with CollectionViewHandler2 and once we merge this PR #23052

rmarinho · 2024-10-10T14:42:59Z

/rebase

rmarinho · 2024-10-10T14:47:56Z

/azp run

azure-pipelines · 2024-10-10T14:48:17Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2024-10-31T11:56:12Z

@kubaflo Could you rebase and fix the conflicts? Thanks in advance.

kubaflo · 2024-12-17T17:33:26Z

@rmarinho it turned out that I had to make some changes to fix it. So, it is not only a UI test now

azure-pipelines · 2024-12-17T17:33:45Z

Azure Pipelines successfully started running 3 pipeline(s).

rmarinho · 2024-12-17T18:56:56Z

Seems is failing for CV2

kubaflo · 2024-12-17T19:05:38Z

@rmarinho Luckily, it is only because the iOS screenshot needs to be updated. Could you please /azp?

rmarinho · 2024-12-18T11:35:02Z

/azp run

azure-pipelines · 2024-12-18T11:35:23Z

Azure Pipelines successfully started running 3 pipeline(s).

rmarinho

Seems the tests are failing for CV2 HeaderShouldNotCollapseWithItems

kubaflo · 2024-12-19T13:55:01Z

@rmarinho hmm, locally it works well with the following change:

Maybe let's try run tests again

rmarinho · 2025-01-07T17:21:16Z

/azp run

azure-pipelines · 2025-01-07T17:21:39Z

Azure Pipelines successfully started running 3 pipeline(s).

rmarinho · 2025-01-07T19:27:58Z

@rmarinho hmm, locally it works well with the following change:

Maybe let's try run tests again

Still failing.
https://dev.azure.com/xamarin/public/_build/results?buildId=131698&view=ms.vss-test-web.build-test-results-tab&runId=3557296&resultId=100092&paneView=attachments

kubaflo · 2025-01-09T00:01:30Z

@rmarinho so this is actually not working on CV2. I will try to get to the bottom of why it doesn't work. But in the meantime can we merge this fix for cv1?

kubaflo · 2025-01-09T00:05:44Z

@rmarinho I've added [FailsOnMacWhenRunningOnXamarinUITest("This is not working for CV2 yet")], so that a PR that fixes it for CV2 will only have to remove it

rmarinho · 2025-01-09T00:09:19Z

/azp run

azure-pipelines · 2025-01-09T00:09:43Z

Azure Pipelines successfully started running 3 pipeline(s).

kubaflo · 2025-01-13T10:30:07Z

Hi @rmarinho! Could it be merged so I can proceed with this one? #27076

rmarinho · 2025-01-22T15:31:40Z

/backport to release/9.0.1xx-sr3

github-actions · 2025-01-22T15:31:53Z

Started backporting to release/9.0.1xx-sr3: https://github.com/dotnet/maui/actions/runs/12911585074

kubaflo requested a review from a team as a code owner April 13, 2024 15:23

kubaflo requested review from StephaneDelcroix and jfversluis April 13, 2024 15:24

dotnet-policy-service bot added the community ✨ Community Contribution label Apr 13, 2024

PureWeen reviewed Apr 15, 2024

View reviewed changes

src/Controls/src/Core/Handlers/Items/iOS/StructuredItemsViewController.cs Outdated Show resolved Hide resolved

jsuarezruiz added platform/ios area-controls-collectionview CollectionView, CarouselView, IndicatorView labels Apr 15, 2024

kubaflo force-pushed the fix-12429 branch from 16cce68 to fa70317 Compare April 15, 2024 18:27

rmarinho reviewed Apr 19, 2024

View reviewed changes

src/Controls/src/Core/Handlers/Items/iOS/StructuredItemsViewController.cs Outdated Show resolved Hide resolved

dotnet deleted a comment from azure-pipelines bot Jun 12, 2024

jsuarezruiz reviewed Jun 12, 2024

View reviewed changes

src/Core/src/Platform/iOS/MauiView.cs Outdated Show resolved Hide resolved

mattleibow reviewed Jul 18, 2024

View reviewed changes

kubaflo force-pushed the fix-12429 branch from f5c4179 to e8da440 Compare July 19, 2024 23:02

PureWeen requested changes Aug 3, 2024

View reviewed changes

github-actions bot force-pushed the fix-12429 branch from e8da440 to 718e416 Compare October 10, 2024 14:43

kubaflo force-pushed the fix-12429 branch from 718e416 to 8d7d563 Compare October 11, 2024 13:10

kubaflo force-pushed the fix-12429 branch from ea608aa to 4b441e1 Compare December 18, 2024 00:32

rmarinho requested changes Dec 18, 2024

View reviewed changes

CollectionView Items display issue when Header is resized on iOS

23d1b2d

kubaflo force-pushed the fix-12429 branch from 4b441e1 to 23d1b2d Compare December 19, 2024 13:55

Disabled a UI test on iOS and Mac

d7b163b

kubaflo mentioned this pull request Jan 11, 2025

CollectionView2 Items display issue when Header/Footer is resized on iOS #27076

Closed

rmarinho approved these changes Jan 14, 2025

View reviewed changes

rmarinho merged commit 70f5aae into dotnet:main Jan 14, 2025
98 of 104 checks passed

rmarinho added this to the .NET 9 SR4 milestone Jan 14, 2025

Tamilarasan-Paranthaman mentioned this pull request Jan 21, 2025

[Testing] Written UI test for the issue reported in PR 27200 #27244

Merged

github-actions bot mentioned this pull request Jan 22, 2025

[release/9.0.1xx-sr3] CollectionView Items display issue when Header is resized on iOS #27285

Closed

kubaflo mentioned this pull request Feb 3, 2025

CollectionView Footer not resizes on ios, 9.0.30 #27537

Closed

github-actions bot locked and limited conversation to collaborators Feb 22, 2025

Comments

Conversation

kubaflo commented Apr 13, 2024

Issues Fixed

Uh oh!

Uh oh!

Uh oh!

rmarinho commented Apr 20, 2024

Uh oh!

azure-pipelines bot commented Apr 20, 2024

Uh oh!

rmarinho commented Apr 22, 2024

Uh oh!

azure-pipelines bot commented Apr 22, 2024

Uh oh!

jsuarezruiz commented May 9, 2024

Uh oh!

azure-pipelines bot commented May 9, 2024

Uh oh!

jsuarezruiz commented Jun 10, 2024

Uh oh!

azure-pipelines bot commented Jun 10, 2024

Uh oh!

Uh oh!

mattleibow left a comment

Choose a reason for hiding this comment

Uh oh!

mattleibow Jul 18, 2024

Choose a reason for hiding this comment

Uh oh!

rmarinho Jul 19, 2024

Choose a reason for hiding this comment

Uh oh!

mattleibow Jul 18, 2024

Choose a reason for hiding this comment

Uh oh!

kubaflo Jul 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PureWeen left a comment

Choose a reason for hiding this comment

Uh oh!

rmarinho commented Oct 10, 2024

Uh oh!

rmarinho commented Oct 10, 2024

Uh oh!

azure-pipelines bot commented Oct 10, 2024

Uh oh!

jsuarezruiz commented Oct 31, 2024

Uh oh!

kubaflo commented Dec 17, 2024

Uh oh!

azure-pipelines bot commented Dec 17, 2024

Uh oh!

rmarinho commented Dec 17, 2024

Uh oh!

kubaflo commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rmarinho commented Dec 18, 2024

Uh oh!

azure-pipelines bot commented Dec 18, 2024

Uh oh!

rmarinho left a comment

Choose a reason for hiding this comment

Uh oh!

kubaflo commented Dec 19, 2024

Uh oh!

rmarinho commented Jan 7, 2025

Uh oh!

azure-pipelines bot commented Jan 7, 2025

Uh oh!

rmarinho commented Jan 7, 2025

Uh oh!

kubaflo commented Jan 9, 2025

Uh oh!

kubaflo commented Jan 9, 2025

Uh oh!

rmarinho commented Jan 9, 2025

kubaflo Jul 19, 2024 •

edited

Loading

kubaflo commented Dec 17, 2024 •

edited

Loading