[Xaml] Simplify loading ResourceDictionary from Source #21429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrozsival
changed the title
simonrozsival
force-pushed
the
dissolve-resources-loader
branch
from
cc86546 to
e500c09
Compare
rmarinho
requested review from
StephaneDelcroix
and removed request for
tj-devel709
rmarinho
requested changes
Mar 26, 2024
…-resources-loader
…-resources-loader
StephaneDelcroix
approved these changes
Mar 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This is a follow-up to #20776. The goal of this PR is to make it easier to enable trimming and AOT analyzers in Controls.Xaml.csproj.
Instead of doing all the XAML resource loading in the
RDSourceTypeConverterand the unintuitive call from Controls.Core into Controls.Xaml through theIResourcesLoaderinterface (resolved via theDependencyService), the XAML parser can load the resource dictionary and call into Controls.Core once it is done.Issues Fixed
Contributes to #19648 and #18658
/cc @StephaneDelcroix