[Docs] Added pending inline comments to Page class#20933
Merged
Conversation
jknaudt21
suggested changes
Mar 1, 2024
Co-authored-by: Juan Diego Herrera <juherrera@microsoft.com>
jknaudt21
suggested changes
Mar 11, 2024
|
|
||
| /// <include file="../../../../docs/Microsoft.Maui.Controls.PlatformConfiguration.iOSSpecific/Page.xml" path="//Member[@MemberName='PrefersHomeIndicatorAutoHidden']/Docs/*" /> | ||
| /// <summary> | ||
| /// Gets a Boolean that indicates whether is allowed to hide the visual indicator for returning to the Home Screen. |
Contributor
There was a problem hiding this comment.
Similar comment as SetPrefersHomeIndicatorAutoHidden
|
|
||
| /// <include file="../../../../docs/Microsoft.Maui.Controls.PlatformConfiguration.iOSSpecific/Page.xml" path="//Member[@MemberName='SetPrefersHomeIndicatorAutoHidden'][2]/Docs/*" /> | ||
| /// <summary> | ||
| /// Sets a Boolean that indicates whether is allowed to hide the visual indicator for returning to the Home Screen. |
Contributor
There was a problem hiding this comment.
How is this property different to SetPrefersHomeIndicatorAutoHidden?
Co-authored-by: Juan Diego Herrera <juherrera@microsoft.com>
Co-authored-by: Juan Diego Herrera <juherrera@microsoft.com>
Co-authored-by: Juan Diego Herrera <juherrera@microsoft.com>
Co-authored-by: Juan Diego Herrera <juherrera@microsoft.com>
Co-authored-by: Juan Diego Herrera <juherrera@microsoft.com>
jknaudt21
reviewed
Mar 25, 2024
Contributor
There was a problem hiding this comment.
This file should be entirely deleted
Contributor
There was a problem hiding this comment.
This file should be entirely deleted
jsuarezruiz
force-pushed
the
page-comments
branch
from
8136301 to
2159676
Compare
jknaudt21
reviewed
May 7, 2024
jknaudt21
previously approved these changes
May 7, 2024
jknaudt21
previously approved these changes
May 8, 2024
PureWeen
requested changes
May 8, 2024
|
|
||
| /// <include file="../../../../docs/Microsoft.Maui.Controls.PlatformConfiguration.WindowsSpecific/Page.xml" path="Type[@FullName='Microsoft.Maui.Controls.PlatformConfiguration.WindowsSpecific.Page']/Docs/*" /> | ||
| /// <summary> | ||
| /// The page instance that Microsoft.Maui.Controls created on the Windows platform. |
Member
There was a problem hiding this comment.
This isn't really correct
This is just an extension class for setting platform specifics
|
|
||
| /// <include file="../../../../docs/Microsoft.Maui.Controls.PlatformConfiguration.WindowsSpecific/Page.xml" path="//Member[@MemberName='SetToolbarPlacement'][1]/Docs/*" /> | ||
| /// <summary> | ||
| /// Sets a value that controls the placement of the toolbar. |
Member
There was a problem hiding this comment.
This doesn't actually do anything right now. Is that useful to note ?
Contributor
Author
There was a problem hiding this comment.
Not implemented
Contributor
Author
There was a problem hiding this comment.
How should we manage this case?
- Include some notes in the docs?
- Implement it?
- Deprecate/remove it.
Contributor
There was a problem hiding this comment.
I think there are 2 approaches here:
- We can make it invisible from the IDE by addding
[EditorBrowsable(EditorBrowsableState.Never)] - Adding a remark saying that this functionality hasn't been implemeted yet.
The ideal scenario would be implementing the missing functionality, but that may go beyond the scop of this PR.
@davidbritch what would be your recommended approach here?
Contributor
There was a problem hiding this comment.
If the API does nothing right now I'd hide it in the IDE.
Contributor
There was a problem hiding this comment.
@jsuarezruiz. With this change I think we should be good to merge. I'd hate for this PR to go stale
jknaudt21
approved these changes
Jun 6, 2024
|
|
||
| /// <include file="../../../../docs/Microsoft.Maui.Controls.PlatformConfiguration.WindowsSpecific/Page.xml" path="//Member[@MemberName='SetToolbarPlacement'][1]/Docs/*" /> | ||
| /// <summary> | ||
| /// Sets a value that controls the placement of the toolbar. |
Contributor
There was a problem hiding this comment.
I think there are 2 approaches here:
- We can make it invisible from the IDE by addding
[EditorBrowsable(EditorBrowsableState.Never)] - Adding a remark saying that this functionality hasn't been implemeted yet.
The ideal scenario would be implementing the missing functionality, but that may go beyond the scop of this PR.
@davidbritch what would be your recommended approach here?
Member
|
/azp run |
PureWeen
approved these changes
Jul 17, 2024
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
samhouts
added
fixed-in-net9.0-nightly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Added pending inline comments to Page class.