Fix Windows device tests #20401
Draft
Fix Windows device tests #20401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
previously approved these changes
Feb 6, 2024
mattleibow
commented
Feb 6, 2024
mattleibow
force-pushed
the
dev/fix-win-animated
branch
2 times, most recently
from
678a5f9
to
c377d9a
Compare
|
Waiting a long time on windows just so we can see how long it really takes instead of slowly incrementing to let the tests finish. |
mattleibow
force-pushed
the
dev/fix-win-animated
branch
3 times, most recently
from
d12ef22
to
55738c8
Compare
mattleibow
changed the title
mattleibow
force-pushed
the
dev/fix-win-animated
branch
2 times, most recently
from
bd65e21
to
7a07c7d
Compare
mattleibow
commented
Feb 12, 2024
Comment on lines
+234
to
+239
| // Some views (like the switch) are animating when the window is shown | ||
| // so we need to wait a few milliseconds for the animation to complete. | ||
| // If the animated views are still a bit flakey, we can increase this to | ||
| // about 250. If we start going above that then there is likely another | ||
| // issue. | ||
| await Task.Delay(100); |
There was a problem hiding this comment.
This is the main fix for a few "flaky tests" that are testing controls that make use of animations. Typically animations only start once the control is on-screen, so we need to wiat for them to actually complete befoer snapshots/testing colros/testing state
|
/rebase |
- Some views need a few ms to finish animating The switch on WinUI needs to animate to "on" so we need to wait a few ms so that the control is ready for the screenshots/color comparisons. - We now have too many tests for WinUI to handle We need to break up all the tests by category to avoid "running out of windows"
github-actions
bot
force-pushed
the
dev/fix-win-animated
branch
from
e8d3217
to
11a001c
Compare
auto-merge was automatically disabled
February 18, 2024 15:34
Pull request was converted to draft
|
Hey @mattleibow, could you rebase it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The switch on WinUI needs to animate to "on" so we need to wait a few ms so that the control is ready for the screenshots/color comparisons.
We need to break up all the tests by category to avoid "running out of windows"
Fixes: