Skip to content

[Android] Fix gesture crash navigating - #19517

Merged
rmarinho merged 22 commits into
mainfrom
fix-19465
May 28, 2025
Merged

[Android] Fix gesture crash navigating#19517
rmarinho merged 22 commits into
mainfrom
fix-19465

Conversation

@jsuarezruiz

@jsuarezruiz jsuarezruiz commented Dec 20, 2023

Copy link
Copy Markdown
Contributor

Description of Change

Quick fix from triage. Fix gesture crash navigating on Android.

Issues Fixed

Fixes #19465

@jsuarezruiz jsuarezruiz added t/bug Something isn't working platform/android area-gestures Gesture types labels Dec 20, 2023
@jsuarezruiz
jsuarezruiz requested a review from a team as a code owner December 20, 2023 08:14
@hartez
hartez removed their request for review January 10, 2024 20:16
@jsuarezruiz
jsuarezruiz requested review from jfversluis and tj-devel709 and removed request for StephaneDelcroix January 22, 2024 15:29
@samhouts samhouts added the stale Indicates a stale issue/pr and will be closed soon label Feb 6, 2024
@jsuarezruiz jsuarezruiz removed the stale Indicates a stale issue/pr and will be closed soon label Feb 7, 2024
@samhouts samhouts added the stale Indicates a stale issue/pr and will be closed soon label Aug 29, 2024
@jsuarezruiz

Copy link
Copy Markdown
Contributor Author

This is really old PR (almost 1 year old) and rebasing, the changes in the Android GestureManager is no longer necessary, so, this PR now only includes an UITests validating the behavior.

@jsuarezruiz

Copy link
Copy Markdown
Contributor Author

/rebase

@jsuarezruiz

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz

Copy link
Copy Markdown
Contributor Author

/rebase

@jsuarezruiz

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz

Copy link
Copy Markdown
Contributor Author

Rebased and tested the test locally:
image

@jsuarezruiz jsuarezruiz removed the stale Indicates a stale issue/pr and will be closed soon label Feb 24, 2025
@jsuarezruiz

Copy link
Copy Markdown
Contributor Author

After some rebases, the PR only includes a tests, the fix have been already applied by another PR.

@rmarinho
rmarinho merged commit 00315fa into main May 28, 2025
@rmarinho
rmarinho deleted the fix-19465 branch May 28, 2025 11:05
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-gestures Gesture types platform/android t/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double tap gesture NullReferenceException when navigating

3 participants