Removed vestigial UpdateContentLayout() method left over from Forms - #18856
Merged
Conversation
Eilon
added
the
area-layout
hartez
force-pushed
the
cv-remove-duplicate-layout
branch
from
November 28, 2023 22:28
bdaf59b to
24f64be
Compare
Member
|
/rebase |
github-actions
Bot
force-pushed
the
cv-remove-duplicate-layout
branch
from
December 20, 2023 15:50
24f64be to
aa8f895
Compare
PureWeen
marked this pull request as ready for review
December 21, 2023 01:02
jpobst
added
platform/android
and removed
partner/android
Member
|
/rebase |
github-actions
Bot
force-pushed
the
cv-remove-duplicate-layout
branch
from
January 20, 2024 19:50
aa8f895 to
63c9709
Compare
Member
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/rebase |
github-actions
Bot
force-pushed
the
cv-remove-duplicate-layout
branch
from
February 11, 2024 00:09
63c9709 to
df986d5
Compare
Member
|
/rebase |
The Forms version of ItemContentView called the UpdateContentLayout method when laying out each RecyclerView item to ensure that all cross-platform layout updates were applied. When the CollectionView was ported to MAUI, that method didn't appropriately handle the changes to margins in the layout, so a call to LayoutVirtualView was added to deal with that. Both methods effectively do the same job, so UpdateContentLayout is now redundant. This change removes UpdateContentLayout so we don't lay out (and in some cases re-measure) the content unnecessarily.
github-actions
Bot
force-pushed
the
cv-remove-duplicate-layout
branch
from
February 14, 2024 22:42
df986d5 to
c4c0674
Compare
Member
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
Test failures unrelated |
PureWeen
approved these changes
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
The Forms version of ItemContentView called the UpdateContentLayout method when laying out each RecyclerView item to ensure that all cross-platform layout updates were applied. When the CollectionView was ported to MAUI, that method didn't appropriately handle the changes to margins in the layout, so a call to LayoutVirtualView was added to deal with that. Both methods effectively do the same job, so UpdateContentLayout is now redundant.
This change removes UpdateContentLayout so we don't lay out (and in some cases re-measure) the content unnecessarily.
Issues Fixed
Does not fully address #18505, but it should help a bit.