Conversation
jsuarezruiz
added
t/bug
ghost
added
the
legacy-area-controls
Contributor
|
@jsuarezruiz the screenshot on the test is empty? |
Contributor
Author
Added an UI Test. |
Contributor
Author
I have reviewed and updated it. |
emaf
previously approved these changes
Oct 6, 2023
emaf
previously approved these changes
Oct 10, 2023
hartez
suggested changes
Oct 12, 2023
Contributor
hartez
left a comment
hartez
left a comment
There was a problem hiding this comment.
Test should be enabled on all the platforms unless there's a compelling reason not to.
jsuarezruiz
removed
the
s/pr-needs-author-input
Contributor
Author
Enabled in all the platforms. Could you review it again?. Thanks! |
hartez
suggested changes
Oct 18, 2023
Contributor
hartez
left a comment
hartez
left a comment
There was a problem hiding this comment.
Don't add new public APIs this late in .NET 8.
hartez
approved these changes
Oct 31, 2023
Eilon
removed
the
legacy-area-controls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix ContentPage BackgroundImageSource not working on iOS/Catalyst.
Issues Fixed
Fixes #17766