[Windows] Allow tap gesture in ContentView #17482
Open
+120
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/bug
jsuarezruiz
changed the title
PureWeen
removed
the
backport/suggested
rmarinho
reviewed
Feb 24, 2025
| @@ -23,6 +23,8 @@ public async Task EntryTextColorStopsWorkingAfterPropertyIsUpdatedFromBinding() | |||
|
|
|||
| await Task.Delay(1000); // Wait for Ripple Effect animation to complete. | |||
|
|
|||
| await Task.Delay(1000); // Wait to complete the Ripple Effect animation. | |||
There was a problem hiding this comment.
do we need both here @jsuarezruiz ? seems we have 2 delays
rmarinho
reviewed
Feb 24, 2025
| { | ||
| var platformContent = content.ToPlatform(mauiContext); | ||
|
|
||
| var defaultBrush = new UI.Xaml.Media.SolidColorBrush(Colors.Transparent.ToWindowsColor()); |
There was a problem hiding this comment.
Should we hardcode the Transparent here? I wonder if we should usa something like a Resource so users could override it if they want at platform level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Allow gestures in Windows ContentView (mostly custom controls).
To validate the changes can use the added sample in the UITest project manually or using the test.
Issues Fixed
Fixes #15810