-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MauiEmbedding extensions should use specified TApp type #16758
Conversation
Hey there @dansiegel! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering TApp is already casted to be IApplication, I would agree that allowing UseMauiApp to use whatever supports it makes sense.
/azp run MAUI-UITests-public |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run MAUI-DeviceTests-public |
Azure Pipelines successfully started running 1 pipeline(s). |
/backport to net7.0 |
Started backporting to net7.0: https://github.com/dotnet/maui/actions/runs/6017943756 |
Description of Change
Fixes registration extensions for UseMauiEmbedding. The extensions now use the TApp specified in the extension.
Issues Fixed
Fixes #16757