Add back support for using MainPage instead of CreateWindow #1262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
changed the title
# Conflicts: # src/Compatibility/Core/src/AppHostBuilderExtensions.Controls.cs # src/Core/src/Platform/Windows/MauiWinUIApplication.cs
mattleibow
commented
Jun 19, 2021
| Debug.WriteLine($"The .NET Purple color is {Resources["DotNetPurple"]}"); | ||
| Debug.WriteLine($"The injected text service had a message: '{textService.GetText()}'"); | ||
|
|
||
| MainPage = Services.GetRequiredService<Page>(); |
There was a problem hiding this comment.
We can use MainPage for single page apps.
| (TestWindow)(this as IApplication).CreateWindow(null); | ||
|
|
||
| protected override IWindow CreateWindow(IActivationState activationState) | ||
| protected override Window CreateWindow(IActivationState activationState) |
There was a problem hiding this comment.
The Windows property is now a list of Control's Window as that is probably what we want at this level.
Comment on lines
+11
to
+16
| // Events called by the Application | ||
| public delegate void OnApplicationCreating(Application application); | ||
| public delegate void OnApplicationCreate(Application application); | ||
| public delegate void OnApplicationLowMemory(Application application); | ||
| public delegate void OnApplicationTrimMemory(Application application, TrimMemory level); | ||
| public delegate void OnApplicationConfigurationChanged(Application application, Configuration newConfig); |
There was a problem hiding this comment.
Add some new application events.
PureWeen
approved these changes
Jun 22, 2021
samhouts
added
the
area-templates
samhouts
added
the
fixed-in-6.0.100-preview.6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR adds the ability for the use of the MainPage property on Application to specify the page, rather than creating a new window which as of yet has no special features.