ActivityIndicator Handlers (#417)

* ActivityIndicatorHandler

* Register IActivityIndicator

* Add comments to IActivityIndicator

* Fix build error

src/Compatibility/Core/src/Android/Renderers/ActivityIndicatorRenderer.cs

@@ -12,6 +12,7 @@ public ActivityIndicatorRenderer(Context context) : base(context)
 			AutoPackage = false;
 		}
 
+		[PortHandler]
 		protected override AProgressBar CreateNativeControl()
 		{
 			return new AProgressBar(Context) { Indeterminate = true };
@@ -42,6 +43,7 @@ protected override void OnElementPropertyChanged(object sender, PropertyChangedE
 				UpdateColor();
 		}
 
+		[PortHandler]
 		void UpdateColor()
 		{
 			if (Element == null || Control == null)
@@ -55,6 +57,7 @@ void UpdateColor()
 				Control.IndeterminateDrawable?.ClearColorFilter();
 		}
 
+		[PortHandler]
 		void UpdateVisibility()
 		{
 			if (Element == null || Control == null)

src/Compatibility/Core/src/iOS/Renderers/ActivityIndicatorRenderer.cs

@@ -5,6 +5,7 @@
 
 namespace Microsoft.Maui.Controls.Compatibility.Platform.iOS
 {
+	[PortHandler]
 	public sealed class UIActivityIndicatorViewDelegate : UIActivityIndicatorView
     {
         ActivityIndicator _element;
@@ -40,6 +41,7 @@ public ActivityIndicatorRenderer()
 
 		}
 
+		[PortHandler]
 		protected override void OnElementChanged(ElementChangedEventArgs<ActivityIndicator> e)
 		{
 			if (e.NewElement != null)
@@ -69,11 +71,13 @@ protected override void OnElementPropertyChanged(object sender, PropertyChangedE
 				UpdateIsRunning();
 		}
 
+		[PortHandler]
 		void UpdateColor()
 		{
 			Control.Color = Element.Color == Color.Default ? null : Element.Color.ToUIColor();
 		}
 
+		[PortHandler]
 		void UpdateIsRunning()
 		{
 			if (Control?.Superview == null)

src/Controls/samples/Controls.Sample/Pages/MainPage.cs

@@ -64,6 +64,8 @@ void SetupMauiLayout()
 			var underlineLabel = new Label { Text = "underline", TextDecorations = TextDecorations.Underline };
 			verticalStack.Add(underlineLabel);
 
+			verticalStack.Add(new ActivityIndicator());
+			verticalStack.Add(new ActivityIndicator { Color = Color.Red, IsRunning = true });
 
 			var button = new Button() { Text = _viewModel.Text, WidthRequest = 200 };
 			var button2 = new Button()

src/Controls/src/Core/ActivityIndicator.cs

@@ -2,7 +2,7 @@
 
 namespace Microsoft.Maui.Controls
 {
-	public class ActivityIndicator : View, IColorElement, IElementConfiguration<ActivityIndicator>
+	public partial class ActivityIndicator : View, IColorElement, IElementConfiguration<ActivityIndicator>
 	{
 		public static readonly BindableProperty IsRunningProperty = BindableProperty.Create("IsRunning", typeof(bool), typeof(ActivityIndicator), default(bool));
 

src/Controls/src/Core/HandlerImpl/ActivityIndicator.Impl.cs

@@ -0,0 +1,7 @@
+namespace Microsoft.Maui.Controls
+{
+	public partial class ActivityIndicator : IActivityIndicator
+	{
+
+	}
+}

src/Core/src/Core/IActivityIndicator.cs

@@ -0,0 +1,20 @@
+namespace Microsoft.Maui
+{
+	/// <summary>
+	/// Represents a View that displays an animation to show that the application is engaged
+	/// in a lengthy activity.
+	/// </summary>
+	public interface IActivityIndicator : IView
+	{
+		/// <summary>
+		/// Gets a value that indicates whether the ActivityIndicator should be visible and animating,
+		/// or hidden.
+		/// </summary>
+		bool IsRunning { get; }
+
+		/// <summary>
+		/// Gets a Color value that defines the display color.
+		/// </summary>
+		Color Color { get; }
+	}
+}

src/Core/src/Handlers/ActivityIndicator/ActivityIndicatorHandler.Android.cs

@@ -0,0 +1,9 @@
+using Android.Widget;
+
+namespace Microsoft.Maui.Handlers
+{
+	public partial class ActivityIndicatorHandler : AbstractViewHandler<IActivityIndicator, ProgressBar>
+	{
+		protected override ProgressBar CreateNativeView() => new ProgressBar(Context) { Indeterminate = true };
+	}
+}

src/Core/src/Handlers/ActivityIndicator/ActivityIndicatorHandler.Standard.cs

@@ -0,0 +1,9 @@
+using System;
+
+namespace Microsoft.Maui.Handlers
+{
+	public partial class ActivityIndicatorHandler : AbstractViewHandler<IActivityIndicator, object>
+	{
+		protected override object CreateNativeView() => throw new NotImplementedException();
+	}
+}

src/Core/src/Handlers/ActivityIndicator/ActivityIndicatorHandler.cs

@@ -0,0 +1,31 @@
+namespace Microsoft.Maui.Handlers
+{
+	public partial class ActivityIndicatorHandler
+	{
+		public static PropertyMapper<IActivityIndicator, ActivityIndicatorHandler> ActivityIndicatorMapper = new PropertyMapper<IActivityIndicator, ActivityIndicatorHandler>(ViewHandler.ViewMapper)
+		{
+			[nameof(IActivityIndicator.IsRunning)] = MapIsRunning,
+			[nameof(IActivityIndicator.Color)] = MapColor
+		};
+
+		public static void MapIsRunning(ActivityIndicatorHandler handler, IActivityIndicator activityIndicator)
+		{
+			handler.TypedNativeView?.UpdateIsRunning(activityIndicator);
+		}
+
+		public static void MapColor(ActivityIndicatorHandler handler, IActivityIndicator activityIndicator)
+		{
+			handler.TypedNativeView?.UpdateColor(activityIndicator);
+		}
+
+		public ActivityIndicatorHandler() : base(ActivityIndicatorMapper)
+		{
+
+		}
+
+		public ActivityIndicatorHandler(PropertyMapper mapper) : base(mapper ?? ActivityIndicatorMapper)
+		{
+
+		}
+	}
+}

src/Core/src/Handlers/ActivityIndicator/ActivityIndicatorHandler.iOS.cs

@@ -0,0 +1,13 @@
+using CoreGraphics;
+using UIKit;
+
+namespace Microsoft.Maui.Handlers
+{
+	public partial class ActivityIndicatorHandler : AbstractViewHandler<IActivityIndicator, NativeActivityIndicator>
+	{
+		protected override NativeActivityIndicator CreateNativeView() => new NativeActivityIndicator(CGRect.Empty, VirtualView)
+		{
+			ActivityIndicatorViewStyle = UIActivityIndicatorViewStyle.Gray
+		};
+	}
+}

src/Core/src/Hosting/AppHostBuilderExtensions.cs

@@ -36,6 +36,7 @@ public static IAppHostBuilder UseMauiHandlers(this IAppHostBuilder builder)
 		{
 			builder.RegisterHandlers(new Dictionary<Type, Type>
 			{
+				{  typeof(IActivityIndicator), typeof(ActivityIndicatorHandler) },
 				{ typeof(IButton), typeof(ButtonHandler) },
 				{ typeof(ICheckBox), typeof(CheckBoxHandler) },
 				{ typeof(IEditor), typeof(EditorHandler) },

src/Core/src/Platform/Android/ActivityIndicatorExtensions.cs

@@ -0,0 +1,21 @@
+using Android.Views;
+using Android.Widget;
+
+namespace Microsoft.Maui
+{
+	public static class ActivityIndicatorExtensions
+	{
+		public static void UpdateIsRunning(this ProgressBar progressBar, IActivityIndicator activityIndicator) =>
+			progressBar.Visibility = activityIndicator.IsRunning ? ViewStates.Visible : ViewStates.Invisible;
+
+		public static void UpdateColor(this ProgressBar progressBar, IActivityIndicator activityIndicator)
+		{
+			Color color = activityIndicator.Color;
+
+			if (!color.IsDefault)
+				progressBar.IndeterminateDrawable?.SetColorFilter(color.ToNative(), FilterMode.SrcIn);
+			else
+				progressBar.IndeterminateDrawable?.ClearColorFilter();
+		}
+	}
+}

src/Core/src/Platform/Standard/ActivityIndicatorExtensions.cs

@@ -0,0 +1,15 @@
+namespace Microsoft.Maui
+{
+	public static class ActivityIndicatorExtensions
+	{
+		public static void UpdateIsRunning(this object nothing, IActivityIndicator activityIndicator)
+		{
+
+		}
+
+		public static void UpdateColor(this object nothing, IActivityIndicator activityIndicator)
+		{
+
+		}
+	}
+}

src/Core/src/Platform/iOS/ActivityIndicatorExtensions.cs

@@ -0,0 +1,18 @@
+namespace Microsoft.Maui
+{
+	public static class ActivityIndicatorExtensions
+	{
+		public static void UpdateIsRunning(this NativeActivityIndicator activityIndicatorView, IActivityIndicator activityIndicator)
+		{
+			if (activityIndicator.IsRunning)
+				activityIndicatorView.StartAnimating();
+			else
+				activityIndicatorView.StopAnimating();
+		}
+
+		public static void UpdateColor(this NativeActivityIndicator activityIndicatorView, IActivityIndicator activityIndicator)
+		{
+			activityIndicatorView.Color = activityIndicator.Color == Color.Default ? null : activityIndicator.Color.ToNative();
+		}
+	}
+}

src/Core/src/Platform/iOS/NativeActivityIndicator.cs

@@ -0,0 +1,35 @@
+using CoreGraphics;
+using UIKit;
+
+namespace Microsoft.Maui
+{
+    public class NativeActivityIndicator : UIActivityIndicatorView
+    {
+        IActivityIndicator? _virtualView;
+
+        public NativeActivityIndicator(CGRect rect, IActivityIndicator? virtualView) : base(rect)
+            => _virtualView = virtualView;
+
+        public override void Draw(CGRect rect)
+        {
+            base.Draw(rect);
+
+            if (_virtualView?.IsRunning == true)
+                StartAnimating();
+        }
+
+        public override void LayoutSubviews()
+        {
+            base.LayoutSubviews();
+
+            if (_virtualView?.IsRunning == true)
+                StartAnimating();
+        }
+
+        protected override void Dispose(bool disposing)
+        {
+            base.Dispose(disposing);
+            _virtualView = null;
+        }
+    }
+}

src/Core/tests/DeviceTests/Handlers/ActivityIndicator/ActivityIndicatorHandlerTests.Android.cs

@@ -0,0 +1,30 @@
+using System;
+using System.Threading.Tasks;
+using Android.Views;
+using Android.Widget;
+using Microsoft.Maui.Handlers;
+
+namespace Microsoft.Maui.DeviceTests
+{
+	public partial class ActivityIndicatorHandlerTests
+	{
+		ProgressBar GetNativeActivityIndicator(ActivityIndicatorHandler activityIndicatorHandler) =>
+			(ProgressBar)activityIndicatorHandler.View;
+
+		bool GetNativeIsRunning(ActivityIndicatorHandler activityIndicatorHandler) =>
+			GetNativeActivityIndicator(activityIndicatorHandler).Visibility == ViewStates.Visible;
+
+		Task ValidateColor(IActivityIndicator activityIndicator, Color color, Action action = null) =>
+			ValidateHasColor(activityIndicator, color, action);
+
+		Task ValidateHasColor(IActivityIndicator activityIndicator, Color color, Action action = null)
+		{
+			return InvokeOnMainThreadAsync(() =>
+			{
+				var nativeActivityIndicator = GetNativeActivityIndicator(CreateHandler(activityIndicator));
+				action?.Invoke();
+				nativeActivityIndicator.AssertContainsColor(color);
+			});
+		}
+	}
+}

src/Core/tests/DeviceTests/Handlers/ActivityIndicator/ActivityIndicatorHandlerTests.cs

@@ -0,0 +1,40 @@
+using System.Threading.Tasks;
+using Microsoft.Maui.DeviceTests.Stubs;
+using Microsoft.Maui.Handlers;
+using Xunit;
+
+namespace Microsoft.Maui.DeviceTests
+{
+	[Category("ActivityIndicatorHandler")]
+	public partial class ActivityIndicatorHandlerTests : HandlerTestBase<ActivityIndicatorHandler, ActivityIndicatorStub>
+	{
+		public ActivityIndicatorHandlerTests(HandlerTestFixture fixture) : base(fixture)
+		{
+		}
+
+		[Theory(DisplayName = "IsRunning Initializes Correctly")]
+		[InlineData(true)]
+		[InlineData(false)]
+		public async Task IsRunningInitializesCorrectly(bool isRunning)
+		{
+			var activityIndicator = new ActivityIndicatorStub()
+			{
+				IsRunning = isRunning
+			};
+
+			await ValidatePropertyInitValue(activityIndicator, () => activityIndicator.IsRunning, GetNativeIsRunning, activityIndicator.IsRunning);
+		}
+
+		[Fact(DisplayName = "BackgroundColor Updates Correctly")]
+		public async Task BackgroundColorUpdatesCorrectly()
+		{
+			var activityIndicator = new ActivityIndicatorStub()
+			{
+				BackgroundColor = Color.Yellow,
+				IsRunning = true
+			};
+
+			await ValidateColor(activityIndicator, Color.Yellow, () => activityIndicator.BackgroundColor = Color.Yellow);
+		}
+	}
+}

src/Core/tests/DeviceTests/Handlers/ActivityIndicator/ActivityIndicatorHandlerTests.iOS.cs

@@ -0,0 +1,28 @@
+using System;
+using System.Threading.Tasks;
+using Microsoft.Maui.Handlers;
+using UIKit;
+using Xunit;
+
+namespace Microsoft.Maui.DeviceTests
+{
+	public partial class ActivityIndicatorHandlerTests
+	{
+		UIActivityIndicatorView GetNativeActivityIndicator(ActivityIndicatorHandler activityIndicatorHandler) =>
+			(UIActivityIndicatorView)activityIndicatorHandler.View;
+
+		bool GetNativeIsRunning(ActivityIndicatorHandler activityIndicatorHandler) =>
+			GetNativeActivityIndicator(activityIndicatorHandler).IsAnimating;
+
+		async Task ValidateColor(IActivityIndicator activityIndicator, Color color, Action action = null)
+		{
+			var expected = await GetValueAsync(activityIndicator, handler =>
+			{
+				var native = GetNativeActivityIndicator(handler);
+				action?.Invoke();
+				return native.BackgroundColor.ToColor();
+			});
+			Assert.Equal(expected, color);
+		}
+	}
+}

src/Core/tests/DeviceTests/Stubs/ActivityIndicatorStub.cs

@@ -0,0 +1,9 @@
+namespace Microsoft.Maui.DeviceTests.Stubs
+{
+	public class ActivityIndicatorStub : StubBase, IActivityIndicator
+	{
+		public bool IsRunning { get; set; }
+
+		public Color Color { get; set; }
+	}
+}