Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build migrated System.ValueTuple #186

Merged
merged 12 commits into from
Jan 9, 2025
Merged

Build migrated System.ValueTuple #186

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
578c78a
Delete unnecessary files.
carlossanlop Nov 22, 2024
fd0ea91
Fix src
carlossanlop Nov 22, 2024
7afb77b
Fix tests
carlossanlop Nov 22, 2024
cdfb9d0
Update System.Memory dependency
carlossanlop Nov 22, 2024
0174ff6
Docs
carlossanlop Nov 22, 2024
c67edd9
Add csprojs to solution
carlossanlop Nov 22, 2024
ab20d1f
Hardcode net462 in placeholder condition.
carlossanlop Nov 25, 2024
83aec4f
Add target that errors when NetMinimum becomes net47.
carlossanlop Nov 25, 2024
303adab
PR feedback
ViktorHofer Jan 8, 2025
8d2163c
Update target name and error condition
ViktorHofer Jan 8, 2025
035ccbc
Fix public key token
ViktorHofer Jan 8, 2025
8f82a73
Merge branch 'main' into BuildSystemValueTuple
ViktorHofer Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add target that errors when NetMinimum becomes net47.
  • Loading branch information
@carlossanlop
carlossanlop committed Nov 25, 2024
commit 83aec4feabd20c311f1cfa390728081de5b34950
8 changes: 6 additions & 2 deletions src/System.ValueTuple/src/System.ValueTuple.csproj
View file
Open in desktop
ViktorHofer marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk" InitialTargets="FailForNet47AsNetMinimum">

<PropertyGroup>
<TargetFrameworks>netstandard2.0;$(NetFrameworkMinimum);net47;netcoreapp2.0</TargetFrameworks>
Expand Down Expand Up @@ -38,4 +38,8 @@
</When>
</Choose>

</Project>
<Target Name="FailForNet47AsNetMinimum" Condition="'$(NetFrameworkMinimum)' == 'net47'">
ViktorHofer marked this conversation as resolved.
Show resolved Hide resolved
<Error Text="NetMinimum is net47 now. Consider removing this implementation or the whole library." />
</Target>

</Project>
Loading