[build] Remove MT.D source build and replace it with a binary #3957

dalexsoto · 2018-04-19T00:20:26Z

This commit removes MonoTouch.Dialog from our source build and
replaces it with a binary from https://github.com/xamarin/macios-binaries/tree/c913506df2d106f9c073f211b7c66b03eefc89f2/MonoTouch.Dialog-Unified

The MT.D hash used in this commit is fixed to migueldeicaza/MonoTouch.Dialog@92c6e14

This commit removes MonoTouch.Dialog from our source build and replaces it with a binary from https://github.com/xamarin/macios-binaries/tree/c913506df2d106f9c073f211b7c66b03eefc89f2/MonoTouch.Dialog-Unified The MT.D hash used in this commit is fixed to migueldeicaza/MonoTouch.Dialog@92c6e14

monojenkins · 2018-04-19T02:08:59Z

Build failure
Build comment file:

✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only)
✅ Generator Diff
🔥 Test run failed 🔥

Test results

14 tests failed, 0 tests skipped, 66 tests passed.

Failed tests

monotouch-test/tvOS - simulator/Debug: BuildFailure
framework-test/tvOS - simulator/Debug: BuildFailure
mini/tvOS - simulator/Debug: BuildFailure
interdependent-binding-projects/tvOS - simulator/Debug: BuildFailure
fsharp/tvOS - simulator/Debug: BuildFailure
introspection/tvOS - simulator/Debug: BuildFailure
dont link/tvOS - simulator/Debug: BuildFailure
dont link/tvOS - simulator/Release: BuildFailure
link all/tvOS - simulator/Debug: BuildFailure
link all/tvOS - simulator/Release: BuildFailure
link sdk/tvOS - simulator/Debug: BuildFailure
link sdk/tvOS - simulator/Release: BuildFailure
monotouch-test/tvOS - simulator/Debug (static registrar): BuildFailure
monotouch-test/tvOS - simulator/Release (all optimizations): BuildFailure

dalexsoto · 2018-04-19T03:05:42Z

Huh? interesting, I am pretty sure I ran the tvOS tests

dalexsoto · 2018-04-19T03:30:46Z

@rolfbjarne do you have an idea why this is happening? I ran make jenkins locally and seems to do the right thing here https://gist.github.com/dalexsoto/c53926dc76c9337455b125a6ecbd4a89

❤️ make runner

…nymore, because we're copying a binary instead of building.

rolfbjarne · 2018-04-19T07:39:22Z

This looked puzzling, so I had a quick look, and just became more puzzled.

I guess I'll have to have a deeper look 👀

monojenkins · 2018-04-19T10:49:27Z

Build failure
Build comment file:

✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only)
✅ Generator Diff
🔥 Test run failed 🔥

Test results

14 tests failed, 0 tests skipped, 66 tests passed.

Failed tests

monotouch-test/tvOS - simulator/Debug: BuildFailure
framework-test/tvOS - simulator/Debug: BuildFailure
mini/tvOS - simulator/Debug: BuildFailure
interdependent-binding-projects/tvOS - simulator/Debug: BuildFailure
fsharp/tvOS - simulator/Debug: BuildFailure
introspection/tvOS - simulator/Debug: BuildFailure
dont link/tvOS - simulator/Debug: BuildFailure
dont link/tvOS - simulator/Release: BuildFailure
link all/tvOS - simulator/Debug: BuildFailure
link all/tvOS - simulator/Release: BuildFailure
link sdk/tvOS - simulator/Debug: BuildFailure
link sdk/tvOS - simulator/Release: BuildFailure
monotouch-test/tvOS - simulator/Debug (static registrar): BuildFailure
monotouch-test/tvOS - simulator/Release (all optimizations): BuildFailure

rolfbjarne · 2018-04-19T12:50:04Z

This makes no sense 😒

I rebuilt & reran the tests manually on the bot, and it worked just fine.

I guess I'll have to add debug code to xharness to see what's going on.

dalexsoto · 2018-04-19T13:57:58Z

we've been (un?)lucky enough to build 3 times under the same bot...

dalexsoto · 2018-04-19T14:18:52Z

@rolfbjarne What xharness binary do we use to run/create the tests? the one we build from source? Or do we use a binary stored somewhere else???

monojenkins · 2018-04-19T15:39:31Z

Build failure
Build comment file:

✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only)
✅ Generator Diff
🔥 Test run failed 🔥

Test results

14 tests failed, 0 tests skipped, 66 tests passed.

Failed tests

monotouch-test/tvOS - simulator/Debug: BuildFailure
framework-test/tvOS - simulator/Debug: BuildFailure
mini/tvOS - simulator/Debug: BuildFailure
interdependent-binding-projects/tvOS - simulator/Debug: BuildFailure
fsharp/tvOS - simulator/Debug: BuildFailure
introspection/tvOS - simulator/Debug: BuildFailure
dont link/tvOS - simulator/Debug: BuildFailure
dont link/tvOS - simulator/Release: BuildFailure
link all/tvOS - simulator/Debug: BuildFailure
link all/tvOS - simulator/Release: BuildFailure
link sdk/tvOS - simulator/Debug: BuildFailure
link sdk/tvOS - simulator/Release: BuildFailure
monotouch-test/tvOS - simulator/Debug (static registrar): BuildFailure
monotouch-test/tvOS - simulator/Release (all optimizations): BuildFailure

monojenkins · 2018-04-19T20:37:33Z

Build failure
Build comment file:

✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only)
✅ Generator Diff
🔥 Test run failed 🔥

Test results

28 tests failed, 0 tests skipped, 52 tests passed.

Failed tests

monotouch-test/tvOS - simulator/Debug: BuildFailure
framework-test/tvOS - simulator/Debug: BuildFailure
mini/tvOS - simulator/Debug: BuildFailure
interdependent-binding-projects/tvOS - simulator/Debug: BuildFailure
fsharp/tvOS - simulator/Debug: BuildFailure
introspection/tvOS - simulator/Debug: BuildFailure
dont link/tvOS - simulator/Debug: BuildFailure
dont link/tvOS - simulator/Release: BuildFailure
link all/tvOS - simulator/Debug: BuildFailure
link all/tvOS - simulator/Release: BuildFailure
link sdk/tvOS - simulator/Debug: BuildFailure
link sdk/tvOS - simulator/Release: BuildFailure
monotouch-test/tvOS - simulator/Debug (static registrar): BuildFailure
monotouch-test/tvOS - simulator/Release (all optimizations): BuildFailure
monotouch-test/watchOS - simulator/Debug: TimedOut
framework-test/watchOS - simulator/Debug: TimedOut
mini/watchOS - simulator/Debug: TimedOut
interdependent-binding-projects/watchOS - simulator/Debug: TimedOut
fsharp/watchOS - simulator/Debug: TimedOut
introspection/watchOS - simulator/Debug: TimedOut
dont link/watchOS - simulator/Debug: TimedOut
dont link/watchOS - simulator/Release: TimedOut
link all/watchOS - simulator/Debug: TimedOut
link all/watchOS - simulator/Release: TimedOut
link sdk/watchOS - simulator/Debug: TimedOut
link sdk/watchOS - simulator/Release: TimedOut
monotouch-test/watchOS - simulator/Debug (static registrar): TimedOut
monotouch-test/watchOS - simulator/Release (all optimizations): TimedOut

monojenkins · 2018-04-20T11:15:57Z

Build success
Build comment file:

✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only)
✅ Generator Diff
✅ Test run succeeded

rolfbjarne · 2018-04-20T11:17:04Z

Yay, I figured out it: it's the code to build the previous revision & calculate the api/generator diff that's interfering.

Now to find a fix...

spouliot · 2018-04-20T15:15:24Z

added do-not-merge label since it's green, approved but now has debugging code that should not be merged.

monojenkins · 2018-04-20T17:08:49Z

Build failure
Build comment file:

✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only)
✅ Generator Diff
🔥 Test run failed 🔥

Test results

14 tests failed, 0 tests skipped, 66 tests passed.

Failed tests

monotouch-test/tvOS - simulator/Debug: BuildFailure
framework-test/tvOS - simulator/Debug: BuildFailure
mini/tvOS - simulator/Debug: BuildFailure
interdependent-binding-projects/tvOS - simulator/Debug: BuildFailure
fsharp/tvOS - simulator/Debug: BuildFailure
introspection/tvOS - simulator/Debug: BuildFailure
dont link/tvOS - simulator/Debug: BuildFailure
dont link/tvOS - simulator/Release: BuildFailure
link all/tvOS - simulator/Debug: BuildFailure
link all/tvOS - simulator/Release: BuildFailure
link sdk/tvOS - simulator/Debug: BuildFailure
link sdk/tvOS - simulator/Release: BuildFailure
monotouch-test/tvOS - simulator/Debug (static registrar): BuildFailure
monotouch-test/tvOS - simulator/Release (all optimizations): BuildFailure

monojenkins · 2018-04-21T00:16:04Z

Build failure
Build comment file:

✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
🔥 Failed to compare API and create generator diff 🔥
✅ Test run succeeded

monojenkins · 2018-04-23T17:16:08Z

Build success
Build comment file:

✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only)
✅ Generator Diff
✅ Test run succeeded

dalexsoto · 2018-04-23T18:08:08Z

Removed the do-not-merge tag since there is no more debug spew and it is now truly green :)

dalexsoto requested review from rolfbjarne and spouliot April 19, 2018 00:20

rolfbjarne added 2 commits April 19, 2018 09:33

Update .gitignore.

d859d17

MonoTouch.Dialog-1.dll doesn't need depend on the platform assembly a…

a2e6c99

…nymore, because we're copying a binary instead of building.

spouliot approved these changes Apr 19, 2018

View reviewed changes

Merge branch 'master' into mtd-binary

6fd2e6e

Add significant debug spew.

92a3aa4

More debugging.

3d3432f

spouliot added the do-not-merge Do not merge this pull request label Apr 20, 2018

Remove debug spew.

2f40ebc

Merge remote-tracking branch 'origin/master' into mtd-binary

2588f81

[compare-commits] Create directory before trying to create files in it.

d5c5c05

dalexsoto removed the do-not-merge Do not merge this pull request label Apr 23, 2018

dalexsoto merged commit 76f0153 into dotnet:master Apr 23, 2018

dalexsoto deleted the mtd-binary branch April 23, 2018 18:09

dalexsoto mentioned this pull request Apr 24, 2018

[compare-commits] Create directory before trying to create files in it. #3977

Closed

[build] Remove MT.D source build and replace it with a binary #3957

[build] Remove MT.D source build and replace it with a binary #3957

Uh oh!

Conversation

dalexsoto commented Apr 19, 2018

Uh oh!

monojenkins commented Apr 19, 2018

Build failure Build comment file:

Test results

Failed tests

Uh oh!

dalexsoto commented Apr 19, 2018

Uh oh!

dalexsoto commented Apr 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rolfbjarne commented Apr 19, 2018

Uh oh!

monojenkins commented Apr 19, 2018

Build failure Build comment file:

Test results

Failed tests

Uh oh!

rolfbjarne commented Apr 19, 2018

Uh oh!

dalexsoto commented Apr 19, 2018

Uh oh!

dalexsoto commented Apr 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

monojenkins commented Apr 19, 2018

Build failure Build comment file:

Test results

Failed tests

Uh oh!

monojenkins commented Apr 19, 2018

Build failure Build comment file:

Test results

Failed tests

Uh oh!

monojenkins commented Apr 20, 2018

Build success Build comment file:

Uh oh!

rolfbjarne commented Apr 20, 2018

Uh oh!

spouliot commented Apr 20, 2018

Uh oh!

monojenkins commented Apr 20, 2018

Build failure Build comment file:

Test results

Failed tests

Uh oh!

monojenkins commented Apr 21, 2018

Build failure Build comment file:

Uh oh!

monojenkins commented Apr 23, 2018

Build success Build comment file:

Uh oh!

dalexsoto commented Apr 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Build failure
Build comment file:

dalexsoto commented Apr 19, 2018 •

edited

Loading

Build failure
Build comment file:

dalexsoto commented Apr 19, 2018 •

edited

Loading

Build failure
Build comment file:

Build failure
Build comment file:

Build success
Build comment file:

Build failure
Build comment file:

Build failure
Build comment file:

Build success
Build comment file:

dalexsoto commented Apr 23, 2018 •

edited

Loading