Switch the mono device/simulator/cross compiler builds to the mono SDK makefile. #3640

vargaz · 2018-03-02T06:18:00Z

Built on wrench too: https://wrench.internalx.com/Wrench/index.aspx?lane=macios-mac-mono-sdk

vargaz · 2018-03-02T06:18:25Z

This is now ready for review etc.

rolfbjarne

Let me also setup a wrench lane, which will make this run our device tests as well.

rolfbjarne · 2018-03-02T09:18:15Z

builds/Makefile

 $(PREFIX)/bin:
 	$(Q) mkdir -p $@

-install-cross: install-llvm64 $(CROSS_TARGETS)
+# Dependency used to build the offsets tool before recursively calling sdk makefiles
+offsets-tool: $(MONO_PATH)/configure


I think this can just depend on $(MONO_PATH)/tools/offsets-tool/MonoAotOffsetsDumper.exe instead:

offsets-tool: $(MONO_PATH)/tools/offsets-tool/MonoAotOffsetsDumper.exe

and then it will be built when needed.

rolfbjarne · 2018-03-02T09:18:42Z

builds/Makefile

 	$(call Q_2,INSTALL ,[LLVM64]) install -c -m 0755 $(INSTALL_STRIP_FLAG) $^ $@

 $(PREFIX)/LLVM/bin:
 	$(Q) mkdir -p $@

-install-llvm64: .stamp-build-llvm64 $(LLVM_TARGETS)
+install-llvm32:


This looks wrong, this target does nothing? If so, it can be removed.

rolfbjarne · 2018-03-02T09:31:56Z

builds/Makefile

+# config/eglib-config.h is needed by the builds in runtime/
+.stamp-build-$(2): $(MONO_PATH)/configure $(MONO_DEPENDENCIES) $(BUILD_DESTDIR)/$(2)
+	$(MAKE) -C $(SDK_BUILDDIR) package-ios-$(3) $(SDK_ARGS)
+	cp -r $(SDK_DESTDIR)/ios-$(3)/lib $(BUILD_DESTDIR)/$(2)


We like quiet builds 😄 i.e.:

$(Q) cp -r $(Q) ...

monojenkins · 2018-03-02T09:33:59Z

Build failure

rolfbjarne · 2018-03-02T09:48:03Z

Wrench builds will show up here: https://wrench.internalx.com/Wrench/index.aspx?lane=macios-mac-mono-sdk

rolfbjarne · 2018-03-02T09:49:13Z

Marking as do-not-merge until we get results from the device tests.

monojenkins · 2018-03-02T15:54:44Z

Build failure

monojenkins · 2018-03-06T01:34:22Z

Build failure

rolfbjarne · 2018-03-06T06:25:17Z

@vargaz another issue found on device:

Dyld Error Message:
Dyld Message: Library not loaded: /Users/builder/data/lanes/5966/fbce4e74/source/xamarin-macios/external/mono/sdks/out/ios-target32s/lib/libmonosgen-2.0.1.dylib
  Referenced from: /private/var/mobile/Containers/Bundle/Application/3B5ED21E-0CAE-4E6A-B426-73BBD2EE2748/mini.app/libxamarin-debug.dylib
  Reason: image not found
  Dyld Version: 370.6

My guess is that you're setting the install name correctly somewhere. This is somewhat complicated: https://github.com/xamarin/xamarin-macios/blob/97ef51bf8b3a0d3b5e16f62f9cfd579821db48ed/builds/Makefile#L1332-L1353

monojenkins · 2018-03-06T19:31:33Z

Build failure

spouliot

sim tests looks good
need device tests results
need to check if this has impact in final app sizes (e.g. incorrect include of extra code in the runtime)

monojenkins · 2018-03-09T01:54:23Z

Build failure

rolfbjarne · 2018-03-12T08:35:15Z

@vargaz there's still an issue with the install path of libmono-profiler-log.dylib on tvOS (iOS seems fine):

Exception Type:  EXC_CRASH (SIGABRT)
Exception Codes: 0x0000000000000000, 0x0000000000000000
Exception Note:  EXC_CORPSE_NOTIFY
Termination Description: DYLD, Library not loaded: /Users/builder/data/lanes/5966/cf75a3c0/source/xamarin-macios/external/mono/sdks/out/ios-targettv/lib/libmonosgen-2.0.1.dylib | Referenced from: /private/var/containers/Bundle/Application/55CF7694-D637-46A7-A32E-822CC93A0EB2/dont link.app/libmono-profiler-log.dylib | Reason: image not found

should be reproducible by running a test app on device with profiling enabled.

monojenkins · 2018-03-12T14:16:33Z

Build failure

vargaz · 2018-03-12T15:00:24Z

@monojenkins build

monojenkins · 2018-03-12T15:50:52Z

Build failure

monojenkins · 2018-03-12T16:00:49Z

Build failure

monojenkins · 2018-03-12T16:33:39Z

Build failure

vargaz · 2018-03-12T23:06:43Z

@monojenkins build

monojenkins · 2018-03-12T23:29:51Z

Build failure

rolfbjarne · 2018-03-14T14:06:21Z

The device tests look good now, there doesn't seem to be anything new compared to master.

spouliot · 2018-03-14T16:32:02Z

last build failed with

make[4]: *** No rule to make target `package-ios-target64-release'.  Stop.

vargaz · 2018-03-15T02:37:05Z

Working on updating them, need to wait for some changes to be merged to 2017-12.

monojenkins · 2018-03-15T03:00:00Z

Build failure

monojenkins · 2018-03-15T20:12:37Z

Build failure

monojenkins · 2018-03-20T20:47:06Z

Build failure

monojenkins · 2018-03-21T03:07:48Z

Build failure

…K makefile. * Build these by recursing into external/mono/sdks/builds and calling the targets there. * Add a few extra rules to build dependencies like llvm and mono's configure to avoid these being build in parallel by the SDK makefile. * Copy config.h/eglib-config.h into builds/install so the build in runtime/ doesn't have to add the builddirs to its includes.

…, so there is no need to run install_name_tool on them.

monojenkins · 2018-03-21T19:58:27Z

Build success

rolfbjarne

No new failures were found in the latest CI device tests, so I think this can be merged now.

rolfbjarne · 2018-03-22T23:30:09Z

It looks like we're still missing app size comparisons.

vargaz · 2018-03-23T01:25:10Z

Will do that after the merge.

vargaz · 2018-03-23T05:17:10Z

There seems to be a size increase, will investigate.

vargaz requested a review from rolfbjarne as a code owner March 2, 2018 06:18

vargaz mentioned this pull request Mar 2, 2018

[WIP] IOS sdk #3521

Closed

rolfbjarne added enable-device-build Makes our build include device support (which we disable for simple PRs to speed them up) run-all-tests Run all our tests. skip-device-tests labels Mar 2, 2018

rolfbjarne requested changes Mar 2, 2018

View reviewed changes

rolfbjarne added the do-not-merge Do not merge this pull request label Mar 2, 2018

spouliot reviewed Mar 8, 2018

View reviewed changes

vargaz force-pushed the ios-sdk2 branch from b11615e to 5b896ed Compare March 12, 2018 15:54

vargaz force-pushed the ios-sdk2 branch from 5b896ed to 6192a28 Compare March 12, 2018 16:10

rolfbjarne approved these changes Mar 14, 2018

View reviewed changes

vargaz self-assigned this Mar 14, 2018

vargaz added 8 commits March 21, 2018 10:57

[builds] Fix install-llvm32 target, make command quiet.

05c01f1

[builds] Link the libraries in runtime/ against the installed libmono…

5951719

…, so there is no need to run install_name_tool on them.

[builds] Fix up the rpath correctly for libmono-profiler-log.dylib.

d0fd78b

[builds] Update to the new ios sdk targets (-release suffix).

8b194a5

Bump mono.

ac32972

Bump mono.

30b14a0

[[builds] Update to the new ios sdk targets (-release suffix).

3214482

vargaz force-pushed the ios-sdk2 branch from 64368bb to 3214482 Compare March 21, 2018 14:58

rolfbjarne approved these changes Mar 22, 2018

View reviewed changes

rolfbjarne added do-not-merge Do not merge this pull request and removed do-not-merge Do not merge this pull request labels Mar 22, 2018

vargaz merged commit 864091d into dotnet:master Mar 23, 2018

Switch the mono device/simulator/cross compiler builds to the mono SDK makefile. #3640

Switch the mono device/simulator/cross compiler builds to the mono SDK makefile. #3640

Uh oh!

Conversation

vargaz commented Mar 2, 2018 • edited by rolfbjarne Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vargaz commented Mar 2, 2018

Uh oh!

rolfbjarne left a comment

Choose a reason for hiding this comment

Uh oh!

rolfbjarne Mar 2, 2018

Choose a reason for hiding this comment

Uh oh!

rolfbjarne Mar 2, 2018

Choose a reason for hiding this comment

Uh oh!

rolfbjarne Mar 2, 2018

Choose a reason for hiding this comment

Uh oh!

monojenkins commented Mar 2, 2018

Uh oh!

rolfbjarne commented Mar 2, 2018

Uh oh!

rolfbjarne commented Mar 2, 2018

Uh oh!

monojenkins commented Mar 2, 2018

Uh oh!

monojenkins commented Mar 6, 2018

Uh oh!

rolfbjarne commented Mar 6, 2018

Uh oh!

monojenkins commented Mar 6, 2018

Uh oh!

spouliot left a comment

Choose a reason for hiding this comment

Uh oh!

monojenkins commented Mar 9, 2018

Uh oh!

rolfbjarne commented Mar 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

monojenkins commented Mar 12, 2018

Uh oh!

vargaz commented Mar 12, 2018

Uh oh!

monojenkins commented Mar 12, 2018

Uh oh!

monojenkins commented Mar 12, 2018

Uh oh!

monojenkins commented Mar 12, 2018

Uh oh!

vargaz commented Mar 12, 2018

Uh oh!

monojenkins commented Mar 12, 2018

Uh oh!

rolfbjarne commented Mar 14, 2018

Uh oh!

spouliot commented Mar 14, 2018

Uh oh!

vargaz commented Mar 15, 2018

Uh oh!

monojenkins commented Mar 15, 2018

Uh oh!

monojenkins commented Mar 15, 2018

Uh oh!

monojenkins commented Mar 20, 2018

Uh oh!

monojenkins commented Mar 21, 2018

Uh oh!

monojenkins commented Mar 21, 2018

Uh oh!

rolfbjarne left a comment

Choose a reason for hiding this comment

Uh oh!

rolfbjarne commented Mar 22, 2018

Uh oh!

vargaz commented Mar 23, 2018

Uh oh!

vargaz commented Mar 2, 2018 •

edited by rolfbjarne

Loading

rolfbjarne commented Mar 12, 2018 •

edited

Loading