[tests] Attempt to fix a random crash in UIDocumentTest.#24165
[tests] Attempt to fix a random crash in UIDocumentTest.#24165rolfbjarne merged 1 commit intomainfrom
Conversation
Attempt to fix a random crash in UIDocumentTest by using a local variable (that is later disposed) instead of an instance variable. The idea is that the instance variable might be freed _during_ the Save method call, while the local variable won't, because it's implicitly disposed (because of the using clause). Hopefully fixes xamarin/maccore#2283.
✅ [PR Build #6cf2c27] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [CI Build #6cf2c27] Build passed (Build packages) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #6cf2c27] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #6cf2c27] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #6cf2c27] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #6cf2c27] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
💻 [CI Build #6cf2c27] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #6cf2c27] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #6cf2c27] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 117 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
3 participants
Attempt to fix a random crash in UIDocumentTest by using a local variable
(that is later disposed) instead of an instance variable.
The idea is that the instance variable might be freed during the Save method
call, while the local variable won't, because it's implicitly disposed
(because of the using clause).
Hopefully fixes https://github.com/xamarin/maccore/issues/2283.