Skip to content

Set a default for the Http3Support feature switch #23223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2025

Conversation

rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Jun 27, 2025

Control over this is moving from dotnet/runtime repo build time to publish time so we need to set a default that matches the old build-time setting.

Ref dotnet/runtime#117012
Ref dotnet/sdk#49564

This is a re-creation of #23221 using origin, since we can't build PRs from forks.

Control over this is moving from dotnet/runtime repo build time to publish time so we need to set a default that matches the old build-time setting.

Ref dotnet/runtime#117012
Ref dotnet/sdk#49564
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #9a7b0f1] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 9a7b0f1b0a9862c5ed884a116a79897a2da91152 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #9a7b0f1] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 9a7b0f1b0a9862c5ed884a116a79897a2da91152 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 9a7b0f1b0a9862c5ed884a116a79897a2da91152 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #9a7b0f1] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 9a7b0f1b0a9862c5ed884a116a79897a2da91152 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #9a7b0f1] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 9a7b0f1b0a9862c5ed884a116a79897a2da91152 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #9a7b0f1] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 9a7b0f1b0a9862c5ed884a116a79897a2da91152 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #9a7b0f1] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 9a7b0f1b0a9862c5ed884a116a79897a2da91152 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #9a7b0f1] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 9a7b0f1b0a9862c5ed884a116a79897a2da91152 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #9a7b0f1] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 117 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 10 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 9a7b0f1b0a9862c5ed884a116a79897a2da91152 [PR build]

@rolfbjarne rolfbjarne merged commit 4c1252d into main Jul 3, 2025
44 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/http3support branch July 3, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants