Skip to content

[tools] Fix a few logging statements. #23106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −3
Open

[tools] Fix a few logging statements. #23106

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44d5671
[tools] Fix a few logging statements.
rolfbjarne Jun 20, 2025
c0ff1e2
Merge remote-tracking branch 'origin/main' into dev/rolf/fix-logging-…
rolfbjarne Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tools/linker/CoreOptimizeGeneratedCode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ static bool MarkInstructions (MethodDefinition method, Mono.Collections.Generic.
// FIXME: calculate the potential constant branch (currently there are no optimizable methods where the switch condition is constant, so this is not needed for now)
var targets = ins.Operand as Instruction [];
if (targets is null) {
Driver.Log (4, $"Can't optimize {0} because of unknown target of branch instruction {1} {2}", method, ins, ins.Operand);
Driver.Log (4, "Can't optimize {0} because of unknown target of branch instruction {1} {2}", method, ins, ins.Operand);
return false;
}
foreach (var target in targets) {
Expand All @@ -354,7 +354,7 @@ static bool MarkInstructions (MethodDefinition method, Mono.Collections.Generic.
}

if (cond_target is null) {
Driver.Log (4, $"Can't optimize {0} because of unknown target of branch instruction {1} {2}", method, ins, ins.Operand);
Driver.Log (4, "Can't optimize {0} because of unknown target of branch instruction {1} {2}", method, ins, ins.Operand);
return false;
}

Expand Down Expand Up @@ -438,7 +438,7 @@ static bool MarkInstructions (MethodDefinition method, Mono.Collections.Generic.
break;
}
default:
Driver.Log ($"Can't optimize {0} because of unknown branch instruction: {1}", method, ins);
Driver.Log ("Can't optimize {0} because of unknown branch instruction: {1}", method, ins);
break;
}

Expand Down
Loading