-
Notifications
You must be signed in to change notification settings - Fork 543
[release/9.0.1xx] Update Xamarin.Messaging and renamed Xamarin paths #23087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/9.0.1xx] Update Xamarin.Messaging and renamed Xamarin paths #23087
Conversation
…lues These can be overriden by CLI builds and will be overriden when building from VS
This is a new dependency after updating the SSH.NET version that Xamarin.Messaging uses
A performance improvement was added in Xamarin.Messaging to avoid copying files from dotnet packs from Windows to Mac, and instead re-define the path: https://dev.azure.com/devdiv/DevDiv/_git/ClientTools.Platform/commit/12c7f2dc0f530a9b40e349573221e490aa4b2659?refName=refs%2Fheads%2Fmain&path=%2Fsrc%2FMessaging%2FCore%2FXamarin.Messaging.Build.Client%2FTaskRunner.cs&_a=compare This is causing side effects in CompileNativeCode, where some values in the "IncludeDirectories" input, points to dotnet packs file that are expected to be present in the output path of the app. This was correct before the improvements mentioned above, but now it's wrong. This change follows the Messaging approach and tries to identify a dotnet pack path, and ensure it points to the dotnet SDK root folder
Brings important changes around Xamarin deprecation and Mac paths
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This PR needs #23097 to be merged first (and then "Update branch" here). |
…ackport-pr-22803-release/9.0.1xx-2025-06-19
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #ce9030c] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #ce9030c] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #ce9030c] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commit.NET ( No breaking changes )✅ API diff vs stable.NET ( No breaking changes )ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💻 [CI Build #ce9030c] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #ce9030c] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #ce9030c] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #ce9030c] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
🚀 [CI Build #ce9030c] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 119 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Brings important changes around Xamarin deprecation and Mac paths:
Backport of #22803.