Skip to content

[release/9.0.1xx] Update Xamarin.Messaging and renamed Xamarin paths #23087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rolfbjarne
Copy link
Member

Brings important changes around Xamarin deprecation and Mac paths:

  • Updated Xamarin.Messaging to 18.0.136-g9e200fbc6d
  • Added target before SayHello to set default Messaging context path values
  • Adapted code to Messaging API changes
  • IL merge BouncyCastle.Cryptography (new SSH.NET dependency)
  • Updated from old Xamarin path to new maui path in test scripts
  • Fixed CompileNativeCode to correctly resolve dotnet packs paths

Backport of #22803.

mauroa and others added 15 commits June 19, 2025 16:06
…lues

These can be overriden by CLI builds and will be overriden when building from VS
This is a new dependency after updating the SSH.NET version that Xamarin.Messaging uses
A performance improvement was added in Xamarin.Messaging to avoid copying files from dotnet packs from Windows to Mac, and instead re-define the path: https://dev.azure.com/devdiv/DevDiv/_git/ClientTools.Platform/commit/12c7f2dc0f530a9b40e349573221e490aa4b2659?refName=refs%2Fheads%2Fmain&path=%2Fsrc%2FMessaging%2FCore%2FXamarin.Messaging.Build.Client%2FTaskRunner.cs&_a=compare

This is causing side effects in CompileNativeCode, where some values in the "IncludeDirectories" input, points to dotnet packs file that are expected to be present in the output path of the app. This was correct before the improvements mentioned above, but now it's wrong.

This change follows the Messaging approach and tries to identify a dotnet pack path, and ensure it points to the dotnet SDK root folder
Brings important changes around Xamarin deprecation and Mac paths
@rolfbjarne rolfbjarne requested review from emaf and mauroa as code owners June 19, 2025 14:07
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne
Copy link
Member Author

This PR needs #23097 to be merged first (and then "Update branch" here).

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #ce9030c] Build passed (Build packages) ✅

Pipeline on Agent
Hash: ce9030c2961ea71fe935cb38b0b9c6f1f40f1af2 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #ce9030c] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: ce9030c2961ea71fe935cb38b0b9c6f1f40f1af2 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #ce9030c] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: ce9030c2961ea71fe935cb38b0b9c6f1f40f1af2 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: ce9030c2961ea71fe935cb38b0b9c6f1f40f1af2 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #ce9030c] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: ce9030c2961ea71fe935cb38b0b9c6f1f40f1af2 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #ce9030c] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: ce9030c2961ea71fe935cb38b0b9c6f1f40f1af2 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #ce9030c] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: ce9030c2961ea71fe935cb38b0b9c6f1f40f1af2 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #ce9030c] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: ce9030c2961ea71fe935cb38b0b9c6f1f40f1af2 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #ce9030c] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 119 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: ce9030c2961ea71fe935cb38b0b9c6f1f40f1af2 [PR build]

@rolfbjarne rolfbjarne merged commit 39b3dac into release/9.0.1xx Jun 23, 2025
44 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/backport-pr-22803-release/9.0.1xx-2025-06-19 branch June 23, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants