Skip to content

[dotnet] Stop suppressing trim analysis warnings. Fixes #21293. #21351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 11 commits into from
Oct 24, 2024
+11 −6
Merged

[dotnet] Stop suppressing trim analysis warnings. Fixes #21293. #21351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cceb557
[dotnet] Stop suppressing trim analysis warnings. Fixes #21293.
rolfbjarne Sep 27, 2024
7c68741
Merge branch 'main' into dev/rolf/dev/rolf/no-trimmer-warning-suppres…
rolfbjarne Oct 4, 2024
5435c45
monotouch-test isn't trimmer-safe.
rolfbjarne Oct 10, 2024
02073b5
Merge remote-tracking branch 'origin/net10.0' into dev/rolf/dev/rolf/…
rolfbjarne Oct 10, 2024
82be9fb
Merge remote-tracking branch 'origin/net10.0' into dev/rolf/dev/rolf/…
rolfbjarne Oct 14, 2024
8a3c11d
Only when actually trimming something.
rolfbjarne Oct 14, 2024
6515f32
Simplify a bit.
rolfbjarne Oct 15, 2024
c0e0ee9
fix
rolfbjarne Oct 15, 2024
2ec3b85
Always enable the roslyn analyzer.
rolfbjarne Oct 15, 2024
0020b3d
Bump Touch.Unit and MonoTouch.Dialog.
rolfbjarne Oct 16, 2024
770d2ee
Revert "fix"
rolfbjarne Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions dotnet/targets/Xamarin.Shared.Sdk.Trimming.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,12 @@
-->
<_OriginalSuppressTrimAnalysisWarnings>$(SuppressTrimAnalysisWarnings)</_OriginalSuppressTrimAnalysisWarnings>
<SuppressTrimAnalysisWarnings Condition="'$(_UseNativeAot)' == 'true'">true</SuppressTrimAnalysisWarnings>
<!-- Otherwise suppress trimmer warnings unless we're trimming all assemblies -->
<SuppressTrimAnalysisWarnings Condition="'$(SuppressTrimAnalysisWarnings)' == '' And '$(TrimMode)' == 'full'">false</SuppressTrimAnalysisWarnings>
<SuppressTrimAnalysisWarnings Condition="'$(SuppressTrimAnalysisWarnings)' == '' And '$(PublishAot)' == 'true'">false</SuppressTrimAnalysisWarnings>
<SuppressTrimAnalysisWarnings Condition="'$(SuppressTrimAnalysisWarnings)' == ''">true</SuppressTrimAnalysisWarnings>

<!-- Otherwise only suppress trimmer warnings if we're not actually trimming any assemblies. -->
<SuppressTrimAnalysisWarnings Condition="'$(SuppressTrimAnalysisWarnings)' == '' And '$(TrimMode)' == 'copy'">true</SuppressTrimAnalysisWarnings>
<SuppressTrimAnalysisWarnings Condition="'$(SuppressTrimAnalysisWarnings)' == '' And '$(TrimMode)' != 'copy'">false</SuppressTrimAnalysisWarnings>

<!-- Always enable trim analyzers. This will report problems in code that's compiled, but not in any referenced packages / NuGets / projects, etc. -->
<EnableTrimAnalyzer Condition="'$(EnableTrimAnalyzer)' == ''">true</EnableTrimAnalyzer>
</PropertyGroup>
</Project>
2 changes: 1 addition & 1 deletion external/MonoTouch.Dialog
Open in desktop
Submodule MonoTouch.Dialog updated 2 files
+2 −0 MonoTouch.Dialog/Reflect.cs
+3 −0 MonoTouch.Dialog/dotnet/shared.csproj
2 changes: 1 addition & 1 deletion external/Touch.Unit
Open in desktop
Submodule Touch.Unit updated 1 files
+2 −0 Touch.Client/dotnet/shared.csproj
2 changes: 2 additions & 0 deletions tests/common/shared-dotnet.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@
<TrimmerSingleWarn Condition="'$(TrimmerSingleWarn)' == ''">false</TrimmerSingleWarn>
<!-- IL2104: Assembly '...' produced trim warnings -->
<NoWarn>$(NoWarn);IL2104</NoWarn>
<!-- Touch.Unit is not trimmer-safe, so ignore any trimmer warnings if we're including Touch.Unit in the build -->
<SuppressTrimAnalysisWarnings Condition="'$(SuppressTrimAnalysisWarnings)' == '' And '$(ExcludeTouchUnitReference)' != 'true'">true</SuppressTrimAnalysisWarnings>
</PropertyGroup>
<Target Name="IgnoreTrimmerWarningsInNUnit" BeforeTargets="PrepareForILLink">
<ItemGroup>
Expand Down