Add documentation on how to provide the Apple Privacy Manifest#20292
Merged
Conversation
mcumming
requested review from
akoeplinger,
dalexsoto,
mandel-macaque and
rolfbjarne
rolfbjarne
reviewed
Mar 12, 2024
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
haritha-mohan
suggested changes
Mar 12, 2024
Co-authored-by: Haritha Mohan <harithamohan@microsoft.com>
Co-authored-by: Haritha Mohan <harithamohan@microsoft.com>
Co-authored-by: Haritha Mohan <harithamohan@microsoft.com>
Co-authored-by: Haritha Mohan <harithamohan@microsoft.com>
haritha-mohan
approved these changes
Mar 13, 2024
jfversluis
reviewed
Mar 15, 2024
jfversluis
reviewed
Mar 15, 2024
jfversluis
reviewed
Mar 15, 2024
jfversluis
left a comment
jfversluis
left a comment
Member
There was a problem hiding this comment.
Found some (minor) things on a second pass
jfversluis
reviewed
Mar 15, 2024
mandel-macaque
approved these changes
Mar 15, 2024
akoeplinger
approved these changes
Mar 16, 2024
akoeplinger
left a comment
akoeplinger
left a comment
Member
There was a problem hiding this comment.
Left a couple comments but looks good overall!
| **Note:** The above guidelines are provided for your convenience. It’s important that you review Apple’s documentation on [privacy manifest files][PrivacyManifestFiles] before creating a privacy manifest for your project. | ||
|
|
||
| **Important:** | ||
| The following information is provided based on Apple's documentation as of March 2024. It is recommended that you review Apple’s documentation on [privacy manifest files][PrivacyManifestFiles] when creating a privacy manifest for your project to ensure you are using the most recent guidelines. If you find any discrepancies in the information below, please [file a bug](https://github.com/dotnet/maui/issues) and include the API in question. |
Member
There was a problem hiding this comment.
should the issue link point to xamarin-macios given that the file lives in that repo?
Contributor
Author
There was a problem hiding this comment.
@dalexsoto And I thought that starting with the .NET MAUI repository was best for issues since we are assuming most of the customers would be reporting for a .NET MAUI app.
| 1. In the `Save As` dialog, leave the filename as `PrivacyInfo` as that is the required name for the file. | ||
| 1. Click `Create` and close Xcode. | ||
| 1. Use Finder to copy the `PrivacyInfo.xcprivacy` file from the Xcode project to your documents folder for now. | ||
| 1. The Xcode project is no longer needed and can be deleted. |
Member
There was a problem hiding this comment.
I'm not sure what the benefit of the detour through Xcode is, I tried it and it just generated the empty skeleton that you have as an example below here anyway.
I'd remove this and let the user start from the example that already has the reasons required by the runtime to simplify the guide.
rolfbjarne
approved these changes
Mar 18, 2024
Comment on lines
+230
to
+238
| 1. Copy the `PrivacyInfo.xcprivacy` from your documents folder to the root folder of your .NET for tvOS project. | ||
| 1. In your favorite text editor, edit the .NET for tvOS csproj project file. | ||
| 1. Add the following elements to the bottom of the root `<Project>` element: | ||
| ```xml | ||
| <ItemGroup Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'tvos'"> | ||
| <BundleResource Include="PrivacyInfo.xcprivacy" LogicalName="PrivacyInfo.xcprivacy" /> | ||
| </ItemGroup> | ||
| ``` | ||
| This will package the file into the tvOS app at the root of the bundle. |
Member
There was a problem hiding this comment.
The same procedure as for iOS (putting in a Resources folder) didn't work for tvOS?
Contributor
Author
There was a problem hiding this comment.
There is no Resources folder in a tvOS app by default.
dalexsoto
approved these changes
Mar 18, 2024
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From https://developer.apple.com/news/?id=3d8a9yyh
Document preview
fixes: #20059