Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Create constructors private and handle that in ComponentCatalog. #922

Merged
merged 1 commit into from
Sep 15, 2018
Merged

Make Create constructors private and handle that in ComponentCatalog. #922

merged 1 commit into from
Sep 15, 2018

Conversation

Ivanidzo4ka
Copy link
Contributor

Fixes #921

sfilipi
sfilipi approved these changes Sep 14, 2018
View reviewed changes
Copy link
Member

@sfilipi sfilipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sfilipi
Copy link
Member

sfilipi commented Sep 14, 2018

thanks @Ivanidzo4ka

@sfilipi sfilipi closed this Sep 14, 2018
@sfilipi sfilipi reopened this Sep 14, 2018
Zruty0
Zruty0 approved these changes Sep 14, 2018
View reviewed changes
Copy link
Contributor

@Zruty0 Zruty0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Ivanidzo4ka Ivanidzo4ka merged commit 8ac5ce8 into dotnet:master Sep 15, 2018
@eerhardt eerhardt mentioned this pull request Nov 6, 2019
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Zruty0 Zruty0 Zruty0 approved these changes

@sfilipi sfilipi sfilipi approved these changes

@dotnet-bot dotnet-bot Awaiting requested review from dotnet-bot

@TomFinley TomFinley Awaiting requested review from TomFinley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ivanidzo4ka @sfilipi @Zruty0