-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Convert repository to NuGet Central Package Management #7482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: ericstj <8918108+ericstj@users.noreply.github.com>
Co-authored-by: ericstj <8918108+ericstj@users.noreply.github.com>
It looks like you might have missed helix.proj and codecoverage.proj. These files aren't built by the root build scripts. You can restore them with |
Co-authored-by: ericstj <8918108+ericstj@users.noreply.github.com>
Fixed! I've converted both helix.proj and codecoverage.proj to use Central Package Management. Added the missing PackageVersion entries (Codecov, ReportGenerator, Microsoft.DotNet.Build.Tasks.Templating) to Directory.Packages.props and removed the Version attributes from their PackageReference items. (2174a03) Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
…L.GenAI.Core Co-authored-by: ericstj <8918108+ericstj@users.noreply.github.com>
…ive analysis Co-authored-by: ericstj <8918108+ericstj@users.noreply.github.com>
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
tools-local/Microsoft.ML.AutoML.SourceGenerator/Microsoft.ML.AutoML.SourceGenerator.csproj
Outdated
Show resolved
Hide resolved
tools-local/Microsoft.ML.AutoML.SourceGenerator/Microsoft.ML.AutoML.SourceGenerator.csproj
Outdated
Show resolved
Hide resolved
tools-local/Microsoft.ML.AutoML.SourceGenerator/Microsoft.ML.AutoML.SourceGenerator.csproj
Outdated
Show resolved
Hide resolved
…etPathWithTargetPlatformMoniker items Co-authored-by: ericstj <8918108+ericstj@users.noreply.github.com>
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
src/Microsoft.Data.Analysis.Interactive/Microsoft.Data.Analysis.Interactive.csproj
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@ericstj left minor question regarding the removed references in the ns2.0 builds in the Microsoft.Data.Analysis.csproj
. It looks build fine. I was just curious about it.
See dotnet/fsharp#18690 When enabling CPM FSProj no longer gets FSharp.Core reference automatically. It needs to be added and represented in CPM.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7482 +/- ##
=======================================
Coverage 68.98% 68.99%
=======================================
Files 1482 1482
Lines 273880 273880
Branches 28254 28254
=======================================
+ Hits 188943 188966 +23
+ Misses 77550 77529 -21
+ Partials 7387 7385 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This PR converts the entire repository to use NuGet Central Package Management as requested in issue #7479. This centralizes all package version management in a single
Directory.Packages.props
file while ensuring the same packages and versions are restored.Changes Made
Core Implementation
Directory.Packages.props
with 89 PackageVersion items organized by category:ManagePackageVersionsCentrally=true
property to activate central package managementVersion Management
eng/Versions.props
(e.g.,$(NewtonsoftJsonVersion)
,$(SystemCollectionsImmutableVersion)
)Package Resolution Validation
Benefits
Validation
The conversion was validated by:
Note: Some GenAI projects have temporary restore failures due to network issues with
JsonSchema.Net.Generation
package from Azure DevOps feeds, but this is unrelated to the central package management conversion and will resolve when the feed is accessible.Fixes #7479.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
dnceng.pkgs.visualstudio.com
dotnet restore Microsoft.ML.sln
(dns block)dotnet restore src/Microsoft.ML.GenAI.LLaMA/Microsoft.ML.GenAI.LLaMA.csproj
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.