Skip to content

Conversation

@carlossanlop
Copy link
Contributor

The latest prerelease versions can be found here: https://dnceng.visualstudio.com/public/_artifacts/feed/dotnet-libraries

Tomorrow we can update to the stable versions after they get published to nuget.

@carlossanlop
Copy link
Contributor Author

carlossanlop commented Nov 12, 2024

I am seeing a new failure and it is coming from System.Data.SqlClient (sni.dll not found):

Microsoft.ML.Tests.DatabaseLoaderTests.IrisSdcaMaximumEntropy [FAIL]
      System.DllNotFoundException : Unable to load DLL 'sni.dll' or one of its dependencies: The specified module could not be found. (0x8007007E)
Finished test: Microsoft.ML.Tests.DatabaseLoaderTests.IrisLightGbmWithTimeout with memory usage 180,908,032.00 and max memory usage 372,355,072.00
      Stack Trace:
           at System.Data.SqlClient.SNINativeMethodWrapper.UnmanagedIsTokenRestricted(IntPtr token, Boolean& isRestricted)
           at System.Data.Win32NativeMethods.IsTokenRestrictedWrapper(IntPtr token)
           at System.Data.ProviderBase.DbConnectionPoolIdentity.GetCurrentNative()
           at System.Data.ProviderBase.DbConnectionPoolIdentity.GetCurrent()
           at System.Data.ProviderBase.DbConnectionPoolGroup.GetConnectionPool(DbConnectionFactory connectionFactory)
           at System.Data.ProviderBase.DbConnectionFactory.GetConnectionPool(DbConnection owningObject, DbConnectionPoolGroup connectionPoolGroup)
           at System.Data.ProviderBase.DbConnectionFactory.TryGetConnection(DbConnection owningConnection, TaskCompletionSource`1 retry, DbConnectionOptions userOptions, DbConnectionInternal oldConnection, DbConnectionInternal& connection)
           at System.Data.ProviderBase.DbConnectionInternal.TryOpenConnectionInternal(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource`1 retry, DbConnectionOptions userOptions)
           at System.Data.ProviderBase.DbConnectionClosed.TryOpenConnection(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource`1 retry, DbConnectionOptions userOptions)
           at System.Data.SqlClient.SqlConnection.TryOpen(TaskCompletionSource`1 retry)
           at System.Data.SqlClient.SqlConnection.Open()
        D:\a\_work\1\s\src\Microsoft.ML.Data\DataLoadSave\Database\DatabaseLoaderCursor.cs(64,0): at Microsoft.ML.Data.DatabaseLoader.Cursor.get_Connection()
        D:\a\_work\1\s\src\Microsoft.ML.Data\DataLoadSave\Database\DatabaseLoaderCursor.cs(76,0): at Microsoft.ML.Data.DatabaseLoader.Cursor.get_Command()
        D:\a\_work\1\s\src\Microsoft.ML.Data\DataLoadSave\Database\DatabaseLoaderCursor.cs(90,0): at Microsoft.ML.Data.DatabaseLoader.Cursor.get_DataReader()
        D:\a\_work\1\s\src\Microsoft.ML.Data\DataLoadSave\Database\DatabaseLoaderCursor.cs(769,0): at Microsoft.ML.Data.DatabaseLoader.Cursor.GetColumnIndex(ColInfo colInfo)
        D:\a\_work\1\s\src\Microsoft.ML.Data\DataLoadSave\Database\DatabaseLoaderCursor.cs(327,0): at Microsoft.ML.Data.DatabaseLoader.Cursor.CreateInt32GetterDelegate(ColInfo colInfo)
        D:\a\_work\1\s\src\Microsoft.ML.Data\DataLoadSave\Database\DatabaseLoaderCursor.cs(205,0): at Microsoft.ML.Data.DatabaseLoader.Cursor.CreateGetterDelegate[TValue](Int32 col)

private DatabaseSource GetIrisDatabaseSource(string command, int commandTimeoutInSeconds = 30)
{
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
#pragma warning disable CS0618 // 'SqlClientFactory' is obsolete: 'Use the Microsoft.Data.SqlClient package instead.'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see this build failure in the previous CI run, but I did hit it in my local machine. If you prefer that I remove these pragmas, let me know, @michaelgsharp .

<MlNetMklDepsVersion>0.0.0.12</MlNetMklDepsVersion>
<MicrosoftExtensionsAIVersion>9.0.0-preview.9.24507.7</MicrosoftExtensionsAIVersion>
<!-- runtime.native.System.Data.SqlClient.sni is not updated by dependency flow as it is not produced live anymore. -->
<RuntimeNativeSystemDataSqlClientSniVersion>4.4.0</RuntimeNativeSystemDataSqlClientSniVersion>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what we did in maintenance-packages to fix the same error in the System.Data.SqlClient unit tests.

<MicrosoftMLOnnxRuntimeVersion>1.18.1</MicrosoftMLOnnxRuntimeVersion>
<MlNetMklDepsVersion>0.0.0.12</MlNetMklDepsVersion>
<MicrosoftExtensionsAIVersion>9.0.0-preview.9.24507.7</MicrosoftExtensionsAIVersion>
<!-- runtime.native.System.Data.SqlClient.sni is not updated by dependency flow as it is not produced live anymore. -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a similar comment in maintenance-packages, but we actually indicate this package's version in Directory.Packages.props (we don't have that here). So I thought it could be useful to have the same comment here, as a reminder that this version won't automatically change.

@codecov
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.88%. Comparing base (e968d32) to head (1a48027).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7301      +/-   ##
==========================================
+ Coverage   68.87%   68.88%   +0.01%     
==========================================
  Files        1470     1470              
  Lines      274005   274005              
  Branches    28403    28403              
==========================================
+ Hits       188725   188756      +31     
+ Misses      77962    77932      -30     
+ Partials     7318     7317       -1     
Flag Coverage Δ
Debug 68.88% <ø> (+0.01%) ⬆️
production 63.30% <ø> (+0.01%) ⬆️
test 89.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/Microsoft.ML.Tests/DatabaseLoaderTests.cs 94.41% <ø> (ø)

... and 7 files with indirect coverage changes

@michaelgsharp
Copy link
Contributor

Merging on red since the only test failures are known test failures and we don't have the repo set up correctly for Build Analysis to be able to bypass it.

@michaelgsharp michaelgsharp merged commit 4a6ce50 into dotnet:main Nov 12, 2024
21 of 25 checks passed
@ericstj
Copy link
Member

ericstj commented Nov 12, 2024

We should remove that reference to SNI. Right fix is here: dotnet/maintenance-packages#169

@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants