-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update dependencies from maintenance-packages to latest versions #7301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I am seeing a new failure and it is coming from System.Data.SqlClient (sni.dll not found): |
| private DatabaseSource GetIrisDatabaseSource(string command, int commandTimeoutInSeconds = 30) | ||
| { | ||
| if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) | ||
| #pragma warning disable CS0618 // 'SqlClientFactory' is obsolete: 'Use the Microsoft.Data.SqlClient package instead.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see this build failure in the previous CI run, but I did hit it in my local machine. If you prefer that I remove these pragmas, let me know, @michaelgsharp .
| <MlNetMklDepsVersion>0.0.0.12</MlNetMklDepsVersion> | ||
| <MicrosoftExtensionsAIVersion>9.0.0-preview.9.24507.7</MicrosoftExtensionsAIVersion> | ||
| <!-- runtime.native.System.Data.SqlClient.sni is not updated by dependency flow as it is not produced live anymore. --> | ||
| <RuntimeNativeSystemDataSqlClientSniVersion>4.4.0</RuntimeNativeSystemDataSqlClientSniVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what we did in maintenance-packages to fix the same error in the System.Data.SqlClient unit tests.
| <MicrosoftMLOnnxRuntimeVersion>1.18.1</MicrosoftMLOnnxRuntimeVersion> | ||
| <MlNetMklDepsVersion>0.0.0.12</MlNetMklDepsVersion> | ||
| <MicrosoftExtensionsAIVersion>9.0.0-preview.9.24507.7</MicrosoftExtensionsAIVersion> | ||
| <!-- runtime.native.System.Data.SqlClient.sni is not updated by dependency flow as it is not produced live anymore. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a similar comment in maintenance-packages, but we actually indicate this package's version in Directory.Packages.props (we don't have that here). So I thought it could be useful to have the same comment here, as a reminder that this version won't automatically change.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7301 +/- ##
==========================================
+ Coverage 68.87% 68.88% +0.01%
==========================================
Files 1470 1470
Lines 274005 274005
Branches 28403 28403
==========================================
+ Hits 188725 188756 +31
+ Misses 77962 77932 -30
+ Partials 7318 7317 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Merging on red since the only test failures are known test failures and we don't have the repo set up correctly for Build Analysis to be able to bypass it. |
|
We should remove that reference to SNI. Right fix is here: dotnet/maintenance-packages#169 |
The latest prerelease versions can be found here: https://dnceng.visualstudio.com/public/_artifacts/feed/dotnet-libraries
Tomorrow we can update to the stable versions after they get published to nuget.