Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add targeting .Net 8.0 for DataFrame package #7168

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

asmirnov82
Copy link
Contributor

Fixes #7167

@JakeRadMSFT
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@asmirnov82
Copy link
Contributor Author

TestTokenizerUsingExternalVocab test fails, because external vocabulary is not available by https://pythia.blob.core.windows.net/public/encoding/gpt2.tiktoken url

@JakeRadMSFT
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.67%. Comparing base (0c51cc6) to head (016dda3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7168      +/-   ##
==========================================
- Coverage   68.94%   68.67%   -0.27%     
==========================================
  Files        1397     1263     -134     
  Lines      266970   257955    -9015     
  Branches    27600    26698     -902     
==========================================
- Hits       184057   177146    -6911     
+ Misses      75807    73996    -1811     
+ Partials     7106     6813     -293     
Flag Coverage Δ
Debug 68.67% <25.00%> (-0.27%) ⬇️
production 62.94% <ø> (-0.59%) ⬇️
test 88.88% <25.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...osoft.Data.Analysis.Tests/ArrowIntegrationTests.cs 100.00% <100.00%> (ø)
...est/Microsoft.Data.Analysis.Tests/ArrayComparer.cs 63.55% <0.00%> (ø)

... and 139 files with indirect coverage changes

@JakeRadMSFT JakeRadMSFT merged commit 8e3f72d into dotnet:main Jun 13, 2024
25 checks passed
@asmirnov82 asmirnov82 deleted the add_net8_target_to_dataframe branch June 13, 2024 19:17
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add targeting .Net 8.0 for DataFrame package
2 participants