Optimize regexes used in tiktoken#7020
Merged
tarekgh merged 3 commits intodotnet:mainfrom Feb 23, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7020 +/- ##
==========================================
- Coverage 68.83% 68.83% -0.01%
==========================================
Files 1258 1258
Lines 250674 250672 -2
Branches 25615 25615
==========================================
- Hits 172561 172543 -18
- Misses 71484 71495 +11
- Partials 6629 6634 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ericstj
reviewed
Feb 22, 2024
tarekgh
approved these changes
Feb 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports the tweaks in openai/tiktoken#234. I noticed the differences as they also show up in the source for https://www.youtube.com/watch?v=zduSFxRajkE.
@tarekgh, if this conflicts with any of your changes, feel free to close this and I can re-make them after your changes land.