Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sweepable estimator to NER #6965

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

zewditu
Copy link
Contributor

@zewditu zewditu commented Jan 19, 2024

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

@ghost ghost assigned zewditu Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f4a389) 68.80% compared to head (d67a232) 68.80%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6965      +/-   ##
==========================================
- Coverage   68.80%   68.80%   -0.01%     
==========================================
  Files        1249     1249              
  Lines      249644   249686      +42     
  Branches    25481    25485       +4     
==========================================
+ Hits       171780   171797      +17     
- Misses      71273    71294      +21     
- Partials     6591     6595       +4     
Flag Coverage Δ
Debug 68.80% <ø> (-0.01%) ⬇️
production 63.27% <ø> (-0.01%) ⬇️
test 88.41% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 15 files with indirect coverage changes

@michaelgsharp michaelgsharp merged commit 125b6d5 into dotnet:main Jan 19, 2024
25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants