Fixes NER to correctly expand/shrink the labels#6928
Merged
michaelgsharp merged 5 commits intodotnet:mainfrom Jan 6, 2024
Merged
Fixes NER to correctly expand/shrink the labels#6928michaelgsharp merged 5 commits intodotnet:mainfrom
michaelgsharp merged 5 commits intodotnet:mainfrom
Conversation
ghost
assigned
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6928 +/- ##
========================================
Coverage 68.80% 68.80%
========================================
Files 1249 1249
Lines 249433 249638 +205
Branches 25510 25481 -29
========================================
+ Hits 171613 171774 +161
- Misses 71210 71271 +61
+ Partials 6610 6593 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jeffhandley
reviewed
Jan 2, 2024
ericstj
reviewed
Jan 2, 2024
tarekgh
reviewed
Jan 2, 2024
tarekgh
reviewed
Jan 2, 2024
tarekgh
reviewed
Jan 2, 2024
tarekgh
reviewed
Jan 2, 2024
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
tarekgh
reviewed
Jan 4, 2024
tarekgh
approved these changes
Jan 5, 2024
Contributor
Author
|
/backport to release/3.0 |
Contributor
|
Started backporting to release/3.0: https://github.com/dotnet/machinelearning/actions/runs/7453507161 |
Contributor
|
@michaelgsharp backporting to release/3.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: ner options fix
Applying: Ner fixed.
error: sha1 information is lacking or useless (src/Microsoft.ML.TorchSharp/NasBert/NerTrainer.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Ner fixed.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
Contributor
|
@michaelgsharp an error occurred while backporting to release/3.0, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
Contributor
Author
|
/backport to release/3.0 |
Contributor
|
Started backporting to release/3.0: https://github.com/dotnet/machinelearning/actions/runs/7454070942 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NER now will correctly expand/shrink the labels when a word is split into multiple tokens.