Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File-scoped namespaces in files under EntryPoints (Microsoft.ML.Core) #6790

Merged
merged 1 commit into from
Aug 25, 2023
Merged

File-scoped namespaces in files under EntryPoints (Microsoft.ML.Core) #6790

merged 1 commit into from
Aug 25, 2023

Conversation

Lehonti
Copy link
Contributor

@Lehonti Lehonti commented Aug 10, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #6790 (eb7c2f1) into main (8952994) will increase coverage by 0.04%.
Report is 5 commits behind head on main.
The diff coverage is 49.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6790      +/-   ##
==========================================
+ Coverage   69.00%   69.05%   +0.04%     
==========================================
  Files        1237     1237              
  Lines      252848   252692     -156     
  Branches    26445    26445              
==========================================
+ Hits       174487   174496       +9     
+ Misses      71424    71266     -158     
+ Partials     6937     6930       -7     
Flag Coverage Δ
Debug 69.05% <49.13%> (+0.04%) ⬆️
production 63.63% <49.13%> (+0.05%) ⬆️
test 88.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
....Data.Analysis/DataFrameColumn.BinaryOperations.cs 0.00% <ø> (ø)
...alysis/PrimitiveDataFrameColumn.BinaryOperators.cs 9.50% <ø> (ø)
...ata.Analysis/PrimitiveDataFrameColumnArithmetic.cs 49.67% <ø> (+0.78%) ⬆️
...crosoft.ML.Core/ComponentModel/ComponentCatalog.cs 70.24% <0.00%> (ø)
src/Microsoft.ML.TorchSharp/Utils/Index.cs 29.41% <0.00%> (ø)
src/Microsoft.ML.TorchSharp/Utils/Range.cs 31.57% <0.00%> (ø)
...eColumn.BinaryOperationImplementations.Exploded.cs 52.27% <31.41%> (+4.61%) ⬆️
...lysis/PrimitiveDataFrameColumn.BinaryOperations.cs 42.00% <35.29%> (+0.47%) ⬆️
...c/Microsoft.ML.Core/EntryPoints/EntryPointUtils.cs 57.35% <55.73%> (ø)
src/Microsoft.ML.Core/EntryPoints/ModuleArgs.cs 57.32% <59.17%> (ø)
... and 4 more

... and 8 files with indirect coverage changes

@michaelgsharp
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@michaelgsharp michaelgsharp merged commit 43a6a81 into dotnet:main Aug 25, 2023
23 checks passed
@Lehonti Lehonti deleted the improvement4 branch August 26, 2023 07:11
@ghost ghost locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants