Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QA sweepable estimator in AutoML #6781

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Add QA sweepable estimator in AutoML #6781

merged 2 commits into from
Aug 3, 2023

Conversation

zewditu
Copy link
Contributor

@zewditu zewditu commented Aug 1, 2023

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #6781 (48a8134) into main (8952994) will increase coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 36.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6781      +/-   ##
==========================================
+ Coverage   69.00%   69.02%   +0.02%     
==========================================
  Files        1237     1237              
  Lines      252848   252692     -156     
  Branches    26445    26445              
==========================================
- Hits       174487   174433      -54     
+ Misses      71424    71312     -112     
- Partials     6937     6947      +10     
Flag Coverage Δ
Debug 69.02% <36.01%> (+0.02%) ⬆️
production 63.60% <36.01%> (+0.02%) ⬆️
test 88.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
....Data.Analysis/DataFrameColumn.BinaryOperations.cs 0.00% <ø> (ø)
...alysis/PrimitiveDataFrameColumn.BinaryOperators.cs 9.50% <ø> (ø)
...ata.Analysis/PrimitiveDataFrameColumnArithmetic.cs 49.67% <ø> (+0.78%) ⬆️
...eColumn.BinaryOperationImplementations.Exploded.cs 52.27% <31.41%> (+4.61%) ⬆️
...lysis/PrimitiveDataFrameColumn.BinaryOperations.cs 42.00% <35.29%> (+0.47%) ⬆️
...lysis/PrimitiveColumnContainer.BinaryOperations.cs 82.85% <100.00%> (-1.36%) ⬇️

... and 13 files with indirect coverage changes

@LittleLittleCloud LittleLittleCloud merged commit ea84d42 into dotnet:main Aug 3, 2023
23 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants