Skip to content

smac - ignore fail trial during initialize #6738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

LittleLittleCloud
Copy link
Contributor

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

fix #dotnet/machinelearning-modelbuilder#2721

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #6738 (f547f40) into main (22342df) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head f547f40 differs from pull request most recent head 0f40c81. Consider uploading reports for the commit 0f40c81 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6738      +/-   ##
==========================================
- Coverage   68.88%   68.88%   -0.01%     
==========================================
  Files        1216     1216              
  Lines      250890   250915      +25     
  Branches    26258    26259       +1     
==========================================
+ Hits       172837   172850      +13     
- Misses      71236    71243       +7     
- Partials     6817     6822       +5     
Flag Coverage Δ
Debug 68.88% <100.00%> (-0.01%) ⬇️
production 63.38% <ø> (-0.01%) ⬇️
test 88.90% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/Microsoft.ML.AutoML.Tests/TunerTests.cs 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

@LittleLittleCloud LittleLittleCloud merged commit 184e661 into dotnet:main Jun 21, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants