Skip to content

Reset DataFrame.RowCount to zero, when DataFrame is empty #6698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2023
Merged

Reset DataFrame.RowCount to zero, when DataFrame is empty #6698

merged 3 commits into from
Jun 13, 2023

Conversation

asmirnov82
Copy link
Contributor

Reset DataFrame.RowCount to zero after Columns collection was cleared or the last column was removed.
Add addtional unit tests on Adding, Inserting and Removing columns in DataFrame

Fixes #6694

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #6698 (8e07da9) into main (d18676b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6698   +/-   ##
=======================================
  Coverage   68.84%   68.85%           
=======================================
  Files        1215     1215           
  Lines      250691   250725   +34     
  Branches    26256    26257    +1     
=======================================
+ Hits       172593   172631   +38     
+ Misses      71278    71271    -7     
- Partials     6820     6823    +3     
Flag Coverage Δ
Debug 68.85% <100.00%> (+<0.01%) ⬆️
production 63.35% <100.00%> (+<0.01%) ⬆️
test 88.88% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...crosoft.Data.Analysis/DataFrameColumnCollection.cs 81.93% <100.00%> (+2.11%) ⬆️
...st/Microsoft.Data.Analysis.Tests/DataFrameTests.cs 99.25% <100.00%> (+<0.01%) ⬆️

... and 10 files with indirect coverage changes

Copy link
Contributor

@michaelgsharp michaelgsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for all your hard work in DataFrames.

@michaelgsharp michaelgsharp merged commit b28710a into dotnet:main Jun 13, 2023
@asmirnov82 asmirnov82 deleted the 6694_fix_rowcount_on_adding_new_column branch June 22, 2023 08:26
@JakeRadMSFT
Copy link
Contributor

Merged into Generic Math branch. (This is just a note for myself)

@ghost ghost locked as resolved and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding new column to empty DataFrame fails
3 participants