Skip to content

Fix DataFrame bounds checking on indexing elements #6681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Fix DataFrame bounds checking on indexing elements #6681

merged 2 commits into from
Jun 13, 2023

Conversation

asmirnov82
Copy link
Contributor

As we have zero-based indexing in C#, ArgumentOutOfRangeException should be thrown not only when index > length, but also when index == length

@michaelgsharp
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Contributor

@michaelgsharp michaelgsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@150e68f). Click here to learn what that means.
The diff coverage is 0.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6681   +/-   ##
=======================================
  Coverage        ?   68.78%           
=======================================
  Files           ?     1215           
  Lines           ?   251729           
  Branches        ?    26256           
=======================================
  Hits            ?   173146           
  Misses          ?    71762           
  Partials        ?     6821           
Flag Coverage Δ
Debug 68.78% <0.00%> (?)
production 63.29% <0.00%> (?)
test 88.88% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Microsoft.Data.Analysis/DataFrameBuffer.cs 82.60% <0.00%> (ø)
...icrosoft.Data.Analysis/PrimitiveDataFrameColumn.cs 81.17% <0.00%> (ø)
...Microsoft.Data.Analysis/ReadOnlyDataFrameBuffer.cs 47.36% <0.00%> (ø)
...c/Microsoft.Data.Analysis/StringDataFrameColumn.cs 71.64% <0.00%> (ø)
.../Microsoft.Data.Analysis/VBufferDataFrameColumn.cs 46.97% <0.00%> (ø)

@michaelgsharp michaelgsharp merged commit 31e4b64 into dotnet:main Jun 13, 2023
@JakeRadMSFT
Copy link
Contributor

Merged into Generic Math branch. (This is just a note for myself)

@ghost ghost locked as resolved and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants