Fix ML.Fairlean using ToList on Row Collection with Count more than Max.Int #6678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6678 +/- ##
=======================================
Coverage 68.77% 68.78%
=======================================
Files 1215 1215
Lines 251556 251556
Branches 26228 26228
=======================================
+ Hits 173004 173026 +22
+ Misses 71737 71720 -17
+ Partials 6815 6810 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
LittleLittleCloud
approved these changes
May 15, 2023
This was referenced May 18, 2023
|
Merged into Generic Math branch. (This is just a note for myself) |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using ToList() method on DataFrame.Rows fails in case of DataFrame.Rows.Count is greater than Max.Int (and as it has Count type long - it's possible).
Instead DataFrame.Append(IEnumerable rows, bool inPlace = false) method should be used.