Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for string vectors to DataFrame #6628

Merged

Conversation

JakeRadMSFT
Copy link
Contributor

@JakeRadMSFT JakeRadMSFT commented Apr 21, 2023

This PR adds support for string vector/"ReadOnlyMemory" vectors.

Relevant issue: #5872

Building on: #6409

@ghost ghost assigned JakeRadMSFT Apr 21, 2023
@JakeRadMSFT JakeRadMSFT marked this pull request as ready for review April 21, 2023 01:50
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #6628 (f7b8346) into main (c0220f7) will decrease coverage by 0.01%.
The diff coverage is 55.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6628      +/-   ##
==========================================
- Coverage   68.38%   68.37%   -0.01%     
==========================================
  Files        1176     1176              
  Lines      248210   248218       +8     
  Branches    25915    25917       +2     
==========================================
- Hits       169743   169731      -12     
- Misses      71689    71711      +22     
+ Partials     6778     6776       -2     
Flag Coverage Δ
Debug 68.37% <55.55%> (-0.01%) ⬇️
production 62.75% <33.33%> (-0.01%) ⬇️
test 88.87% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../Microsoft.Data.Analysis/VBufferDataFrameColumn.cs 46.97% <0.00%> (-0.51%) ⬇️
src/Microsoft.Data.Analysis/IDataView.Extension.cs 91.89% <66.66%> (+0.16%) ⬆️
...oft.Data.Analysis.Tests/DataFrameIDataViewTests.cs 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@michaelgsharp michaelgsharp merged commit c696e09 into dotnet:main Apr 21, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants