Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes one dal dispatching issues #6547

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

michaelgsharp
Copy link
Member

Fixes the onedal dispatching issues by using dynamic checking instead of static.

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #6547 (11200ff) into main (eeba2ee) will increase coverage by 0.04%.
The diff coverage is 60.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6547      +/-   ##
==========================================
+ Coverage   68.39%   68.44%   +0.04%     
==========================================
  Files        1174     1174              
  Lines      248049   248045       -4     
  Branches    25909    25909              
==========================================
+ Hits       169661   169778     +117     
+ Misses      71614    71514     -100     
+ Partials     6774     6753      -21     
Flag Coverage Δ
Debug 68.44% <60.00%> (+0.04%) ⬆️
production 62.83% <60.00%> (+0.06%) ⬆️
test 88.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...icrosoft.ML.FastTree/RandomForestClassification.cs 50.76% <0.00%> (-0.23%) ⬇️
...rc/Microsoft.ML.FastTree/RandomForestRegression.cs 53.69% <0.00%> (-0.08%) ⬇️
...Microsoft.ML.Mkl.Components/OlsLinearRegression.cs 56.04% <0.00%> (-0.02%) ⬇️
src/Microsoft.ML.Data/MLContext.cs 89.65% <75.00%> (-3.83%) ⬇️
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 79.48% <0.00%> (-20.52%) ⬇️
src/Microsoft.ML.Core/Data/ProgressReporter.cs 70.95% <0.00%> (-6.99%) ⬇️
src/Microsoft.ML.Maml/MAML.cs 25.88% <0.00%> (-1.02%) ⬇️
.../Microsoft.ML.TorchSharp/NasBert/NasBertTrainer.cs 83.64% <0.00%> (+0.17%) ⬆️
src/Microsoft.ML.Data/Utils/LossFunctions.cs 67.35% <0.00%> (+0.51%) ⬆️
...oft.ML.StandardTrainers/Standard/SdcaMulticlass.cs 92.49% <0.00%> (+1.02%) ⬆️
... and 6 more

@dakersnar
Copy link
Contributor

Can you elaborate on what the original problem was and how this fixes it?

@michaelgsharp
Copy link
Member Author

@dakersnar this is the issue I brought up in last weeks pod sync. Since we had a static reference to the one dal code if you didn't have the binary it would crash. This changes it from a static check to a dynamic check and handles it correctly. Its the code sample shared by @tannergooding

@michaelgsharp michaelgsharp merged commit 9181467 into dotnet:main Jan 24, 2023
@michaelgsharp michaelgsharp deleted the one-dal-fix branch January 24, 2023 19:52
@ghost ghost locked as resolved and limited conversation to collaborators Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants