Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WebClient to HttpClient implementations for downloading (WIP) #6476

Merged
merged 9 commits into from
May 4, 2023

Conversation

rgesteve
Copy link
Contributor

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

WebClient marked as obsolete.

This is the first file (of at least three) that requires similar changes.

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #6476 (f33004a) into main (42788c4) will decrease coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6476      +/-   ##
==========================================
- Coverage   68.57%   68.57%   -0.01%     
==========================================
  Files        1171     1171              
  Lines      247197   247197              
  Branches    25799    25799              
==========================================
- Hits       169515   169510       -5     
- Misses      70959    70961       +2     
- Partials     6723     6726       +3     
Flag Coverage Δ
Debug 68.57% <ø> (-0.01%) ⬇️
production 62.96% <ø> (-0.01%) ⬇️
test 88.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 89.61% <0.00%> (-0.64%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.38% <0.00%> (-0.15%) ⬇️

@michaelgsharp
Copy link
Member

Merging on red since its just a doc addition.

@michaelgsharp michaelgsharp merged commit ce9938d into dotnet:main May 4, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants