-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add SetMaximumMemoryUsageInMegaByte in AutoMLExperiment #6305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
LittleLittleCloud
merged 23 commits into
dotnet:main
from
LittleLittleCloud:u/xiaoyun/memoryLimit
Sep 8, 2022
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
fc6379d
add IPerformanceMonitor
LittleLittleCloud 045244a
implement DefaultPerformanceMonitor
LittleLittleCloud c611afd
implement memory restricution
LittleLittleCloud 313d8d4
update
LittleLittleCloud 87f8734
update
LittleLittleCloud 82c7075
update
LittleLittleCloud d091aad
update
LittleLittleCloud e49d9b9
add trace
LittleLittleCloud b4f2007
add checkalive
LittleLittleCloud 9fc36b0
add test for fast tree cancellation
LittleLittleCloud 3f4f29d
add log
LittleLittleCloud 039fb8f
add log to automl
LittleLittleCloud 26e6642
lower refreshing speed
LittleLittleCloud 90f1f8d
add cancellation check to lgbm and add test
LittleLittleCloud cc1ca68
dispose ml context
LittleLittleCloud 3c96c4e
update
LittleLittleCloud 937aa8a
fix tests
LittleLittleCloud 16eeeae
fix based on comment
LittleLittleCloud 6bf4360
fix comments
LittleLittleCloud b1d50c0
fix time convertion error
LittleLittleCloud b517c9f
add log to AutoMLExperiment_cancel_trial_when_exceeds_memory_limit_Async
LittleLittleCloud 29bbc26
rename catelogical column
LittleLittleCloud 5496403
use dummy performance monitor
LittleLittleCloud File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use IDisposable with this class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great question here. The IDisposable pattern is mainly because I want to make sure
MLContext.CancelExecuation
get called and set to null after the trial is finished while I don't want to explicitly call it's deconstructor or call GC. But I can go another route if you have any recommendation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dispose pattern is not only for GC finalization or deconstruction. It is used to clean up any object when done using it. You already implemented the Dispose method. Having IDisposable will benefit with the
using ()
code pattern.