Fix official build #626
Merged
Fix official build #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nux. But building native now requires a Restore to happen first.
|
Thank you very much for the fix! |
codemzs
approved these changes
Aug 1, 2018
safern
approved these changes
Aug 1, 2018
There was a problem hiding this comment.
LGTM.
I just have a question would: https://github.com/eerhardt/machinelearning/blob/46374da079f0d52cbe8b96134510dd61dd3a7506/build.proj#L33
Cause this target to be run twice?
No. MSBuild targets don't run twice. https://docs.microsoft.com/en-us/visualstudio/msbuild/target-build-order
|
Oh yeah, you're right, completely forgot about that. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our official build is broken because we introduced a new dependency when building native code.
Previously, when we built native code, we didn't need to restore NuGet packages. But with #624 we now have a dependency from our native C++ code to the MklImports NuGet package. And our build fails if the package hasn't been restored.
The fix is to make
BuildNativedependent onRestorePackages.