Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add spec for sweepable pipeline #6218

Conversation

LittleLittleCloud
Copy link
Contributor

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #6218 (805ebb3) into main (85a9d9e) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6218      +/-   ##
==========================================
- Coverage   68.33%   68.33%   -0.01%     
==========================================
  Files        1102     1102              
  Lines      242323   242323              
  Branches    25174    25174              
==========================================
- Hits       165601   165593       -8     
- Misses      70156    70163       +7     
- Partials     6566     6567       +1     
Flag Coverage Δ
Debug 68.33% <ø> (-0.01%) ⬇️
production 62.77% <ø> (-0.01%) ⬇️
test 88.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 79.48% <0.00%> (-20.52%) ⬇️

@michaelgsharp michaelgsharp merged commit 84f92dd into dotnet:main Jun 9, 2022
@LittleLittleCloud LittleLittleCloud mentioned this pull request Jun 9, 2022
4 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Jul 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants