Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from XliffTasks to Microsoft.DotNet.XliffTasks #5887

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Move from XliffTasks to Microsoft.DotNet.XliffTasks #5887

merged 1 commit into from
Jul 28, 2021

Conversation

premun
Copy link
Member

@premun premun commented Jul 26, 2021

The package name was changed to start with a reserved name (dotnet/xliff-tasks#412)

@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #5887 (128e1f9) into main (d6f7922) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5887   +/-   ##
=======================================
  Coverage   68.18%   68.19%           
=======================================
  Files        1142     1142           
  Lines      242367   242367           
  Branches    25355    25355           
=======================================
+ Hits       165268   165271    +3     
+ Misses      70414    70412    -2     
+ Partials     6685     6684    -1     
Flag Coverage Δ
Debug 68.19% <ø> (+<0.01%) ⬆️
production 62.87% <ø> (+<0.01%) ⬆️
test 88.56% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...est/Microsoft.ML.Core.Tests/UnitTests/TestHosts.cs 96.55% <0.00%> (-3.45%) ⬇️
...StandardTrainers/Standard/LinearModelParameters.cs 66.07% <0.00%> (+0.25%) ⬆️
src/Microsoft.ML.Data/DataView/CacheDataView.cs 84.64% <0.00%> (+0.67%) ⬆️

@premun
Copy link
Member Author

premun commented Jul 28, 2021

@michaelgsharp do you know whom to ask for a review here? This is just a simple package name change (for Maestro
dependency flow purposes)

@michaelgsharp
Copy link
Member

Me. And it looks good. I'll get it in.

Copy link
Member

@michaelgsharp michaelgsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@michaelgsharp michaelgsharp merged commit 526215d into dotnet:main Jul 28, 2021
@premun premun deleted the prvysoky/xlifftasks branch July 28, 2021 16:42
@premun
Copy link
Member Author

premun commented Jul 28, 2021

Thanks!

darth-vader-lg added a commit to darth-vader-lg/ML-NET that referenced this pull request Aug 15, 2021
* remotes/official/main:
  Move from XliffTasks to Microsoft.DotNet.XliffTasks (dotnet#5887)
@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants