Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5813 dataframe improve exception text #5819

Merged
merged 4 commits into from
May 28, 2021
Merged

#5813 dataframe improve exception text #5819

merged 4 commits into from
May 28, 2021

Conversation

asmirnov82
Copy link
Contributor

Fixes #5813

Enhance error description in ArgumentException on accessing not existing column in DataFrame by adding column name into the exception message

@pgovind pgovind self-requested a review May 28, 2021 21:15
@pgovind pgovind added the Microsoft.Data.Analysis All DataFrame related issues and PRs label May 28, 2021
Copy link
Contributor

@pgovind pgovind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #5819 (d431028) into main (7fafbf3) will increase coverage by 0.05%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #5819      +/-   ##
==========================================
+ Coverage   68.32%   68.38%   +0.05%     
==========================================
  Files        1131     1131              
  Lines      241291   241291              
  Branches    25053    25053              
==========================================
+ Hits       164863   165000     +137     
+ Misses      69923    69801     -122     
+ Partials     6505     6490      -15     
Flag Coverage Δ
Debug 68.38% <33.33%> (+0.05%) ⬆️
production 63.00% <33.33%> (+0.07%) ⬆️
test 89.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Microsoft.Data.Analysis/DataFrame.cs 86.40% <0.00%> (ø)
...crosoft.Data.Analysis/DataFrameColumnCollection.cs 79.91% <100.00%> (ø)
src/Microsoft.ML.Maml/MAML.cs 24.75% <0.00%> (-1.46%) ⬇️
...StandardTrainers/Standard/LinearModelParameters.cs 66.32% <0.00%> (+0.25%) ⬆️
src/Microsoft.ML.Data/Utils/LossFunctions.cs 67.35% <0.00%> (+0.51%) ⬆️
...oft.ML.StandardTrainers/Standard/SdcaMulticlass.cs 92.49% <0.00%> (+1.02%) ⬆️
...crosoft.ML.StandardTrainers/Optimizer/Optimizer.cs 73.12% <0.00%> (+1.15%) ⬆️
src/Microsoft.ML.Sweeper/AsyncSweeper.cs 72.78% <0.00%> (+1.36%) ⬆️
...crosoft.ML.StandardTrainers/Standard/SdcaBinary.cs 88.56% <0.00%> (+3.07%) ⬆️
src/Microsoft.ML.Data/Training/TrainerUtils.cs 69.67% <0.00%> (+3.81%) ⬆️
... and 2 more

@pgovind pgovind merged commit 09265b0 into dotnet:main May 28, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Microsoft.Data.Analysis All DataFrame related issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve exception text on grouping by invalid column name in DataFrame
2 participants