Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unix instructions for x-compiling on ARM #5811

Merged
merged 1 commit into from
May 27, 2021

Conversation

luisquintanilla
Copy link
Contributor

Added binutils-aarch64-linux-gnu installation instructions and reference to Docker image.

Fixes #5806

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

@luisquintanilla
Copy link
Contributor Author

@michaelgsharp ready for review

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #5811 (7c7e53d) into main (7fafbf3) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5811      +/-   ##
==========================================
+ Coverage   68.32%   68.38%   +0.06%     
==========================================
  Files        1131     1131              
  Lines      241291   241291              
  Branches    25053    25053              
==========================================
+ Hits       164863   165014     +151     
+ Misses      69923    69791     -132     
+ Partials     6505     6486      -19     
Flag Coverage Δ
Debug 68.38% <ø> (+0.06%) ⬆️
production 63.01% <ø> (+0.07%) ⬆️
test 89.26% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Microsoft.ML.Maml/MAML.cs 24.75% <0.00%> (-1.46%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.67% <0.00%> (+0.14%) ⬆️
...StandardTrainers/Standard/LinearModelParameters.cs 66.32% <0.00%> (+0.25%) ⬆️
src/Microsoft.ML.Data/Utils/LossFunctions.cs 67.35% <0.00%> (+0.51%) ⬆️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 85.59% <0.00%> (+0.84%) ⬆️
...oft.ML.StandardTrainers/Standard/SdcaMulticlass.cs 92.49% <0.00%> (+1.02%) ⬆️
...crosoft.ML.StandardTrainers/Optimizer/Optimizer.cs 73.12% <0.00%> (+1.15%) ⬆️
src/Microsoft.ML.Sweeper/AsyncSweeper.cs 72.78% <0.00%> (+1.36%) ⬆️
test/Microsoft.ML.AutoML.Tests/AutoFitTests.cs 89.04% <0.00%> (+1.96%) ⬆️
...crosoft.ML.StandardTrainers/Standard/SdcaBinary.cs 88.56% <0.00%> (+3.07%) ⬆️
... and 4 more

Copy link
Member

@michaelgsharp michaelgsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for pushing the fix luis!

@michaelgsharp michaelgsharp merged commit 7c34ab9 into dotnet:main May 27, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Linux Build Instructions
2 participants