Correcting docs for building in Linux #58
Conversation
Related to: dotnet#57
| * curl | ||
| * All the requirements necessary to run .NET Core 2.0 applications |
There was a problem hiding this comment.
Do we want to add the command to get all this? So that people can just copy and paste? Just like in corefx:
There was a problem hiding this comment.
@safern how about I point to https://docs.microsoft.com/en-us/dotnet/core/linux-prerequisites?tabs=netcore2x instead for a more comprehensive list (listing not only ubuntu)?
| * libunwind | ||
| * git | ||
| * clang-3.9 | ||
| * cmake |
There was a problem hiding this comment.
It would be good to list a minimum cmake version.
| @@ -14,21 +14,18 @@ For more information about the different options when building, run `build.sh -? | |||
| ## Minimum Hardware Requirements | |||
| - 2GB RAM | |||
There was a problem hiding this comment.
Can you add x64 here as well? We only support building on an x64 machine.
|
|
||
| ### Linux | ||
|
|
||
| First, the package lists might need to be updated | ||
| For Ubuntu, the following components are needed: |
There was a problem hiding this comment.
We get pretty heavily into Ubuntu here, but no other distro. It almost makes it sound like we only support building on Ubuntu, which isn't the case.
Can we just list our direct dependencies (git, cmake with minimum version, clang with minimum version), and then say And all the requirements necessary to run .NET Core 2.0 applications with the link to the docs site?
There was a problem hiding this comment.
I agree with you, my intention though was to spell out the commands and to be consistent with corefx (there is also only instructions for ubuntu).
I'll push up another commit to address this feedback.
|
|
||
| On Linux, the following components are needed | ||
| For more information on prerequisites in different linux distribution for .NET Core on Linux click [here](https://docs.microsoft.com/en-us/dotnet/core/linux-prerequisites?tabs=netcore2x). |
There was a problem hiding this comment.
This sounds redundant calling linux twice right away and in one place linux is with lower l and in the other with capital L. I would probably write it like:
For more information on prerequisites in different linux distribution for .NET Core click here
| @@ -13,31 +13,40 @@ For more information about the different options when building, run `build.sh -? | |||
|
|
|||
| ## Minimum Hardware Requirements | |||
| - 2GB RAM | |||
There was a problem hiding this comment.
Recommend adding ./ as "run ./build.sh -? " to remind users that they will need it.
* Correcting docs for building in linux Related to: dotnet#57 * Adding more description * Providing link for further information * Improving docs * Making less ubuntu centric. * Adding pre-req link for macOS * Improving sentences
ghost
locked as resolved and limited conversation to collaborators
This PR updates the unix instructions for building this repo on Linux.
As prerequisite we need to use clang-3.9 in order to build machinelearning repo on Linux.
cc: @eerhardt @danmosemsft @safern
Related to: #57