Updated arcade to the latest version

[michaelgsharp]

Since we don't have it set up to automatically update arcade yet, this PR manually updates arcade to the latest version.

[ericstj]

MSBUILD : error MSB1021: Cannot create an instance of the logger. The given assembly name or codebase was invalid. (0x80131047)
Switch: /home/vsts_azpcontainer/.nuget/packages/microsoft.dotnet.arcade.sdk/6.0.0-beta.21253.2/tools/netcoreapp2.1/Microsoft.DotNet.Arcade.Sdk.dll

If I look at that package it doesn't have this path: tools/netcoreapp2.1 I think you need to update something to tools/netcoreapp3.1. Perhaps in our own yml somewhere?

[ericstj]

Here it is:

machinelearning/eng/common/tools.sh

Line 312 in 04dda55

_InitializeBuildToolFramework="netcoreapp2.1"

And here:

machinelearning/eng/common/tools.ps1

Line 498 in 19b2331

$buildTool = @{ Path = $dotnetPath; Command = 'msbuild'; Tool = 'dotnet'; Framework = 'netcoreapp2.1' }

I would have expected these to be updated as part of manual update.

[ericstj]

Looks like you're missing all changes that should have been applied in eng/common. Darc update should copy those files to make them same version as arcade version you're picking up.

[codecov]

Codecov Report

Merging #5783 (a4a7350) into main (fe477ca) will decrease coverage by 0.04%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #5783      +/-   ##
==========================================
- Coverage   68.39%   68.34%   -0.05%     
==========================================
  Files        1131     1131              
  Lines      241008   241204     +196     
  Branches    25025    25039      +14     
==========================================
+ Hits       164833   164862      +29     
- Misses      69693    69844     +151     
- Partials     6482     6498      +16     

Flag	Coverage Δ
Debug	68.34% <33.33%> (-0.05%)	⬇️
production	62.96% <100.00%> (-0.08%)	⬇️
test	89.24% <0.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...t/Microsoft.ML.PerformanceTests/Harness/Configs.cs	0.00% <0.00%> (ø)
src/Microsoft.ML.Core/Utilities/ThreadUtils.cs	83.67% <100.00%> (ø)
...osoft.ML.KMeansClustering/KMeansPlusPlusTrainer.cs	83.60% <0.00%> (-7.16%)	⬇️
src/Microsoft.ML.FastTree/Training/StepSearch.cs	57.42% <0.00%> (-4.96%)	⬇️
src/Microsoft.ML.Data/Training/TrainerUtils.cs	65.86% <0.00%> (-3.82%)	⬇️
src/Microsoft.Data.Analysis/DataFrame.Join.cs	94.73% <0.00%> (-3.16%)	⬇️
...crosoft.ML.StandardTrainers/Standard/SdcaBinary.cs	85.49% <0.00%> (-3.08%)	⬇️
test/Microsoft.ML.AutoML.Tests/AutoFitTests.cs	87.07% <0.00%> (-1.97%)	⬇️
src/Microsoft.ML.Sweeper/AsyncSweeper.cs	71.42% <0.00%> (-1.37%)	⬇️
...crosoft.ML.StandardTrainers/Optimizer/Optimizer.cs	71.96% <0.00%> (-1.16%)	⬇️
... and 21 more

[ericstj]

Took a look at the failing code-coverage run. It seems like it timed out while running tests.

It seems to be Microsoft.ML.Tests like we were seeing before:
https://dev.azure.com/dnceng/public/_build/results?buildId=1138394&view=logs&j=12b34f85-96db-5b04-05cf-faf2be278867&t=557f61c0-297e-5c2f-1c50-9536da345a61

However I don't see an obvious hanging test:
https://dev.azure.com/dnceng/_apis/resources/Containers/7060027/Windows_x64%20D?itemPath=Windows_x64%20D%2Fartifacts%2Flog%2FDebug%2FMicrosoft.ML.Tests_netcoreapp2.1_x64.log

[michaelgsharp]

@ericstj so just a retrigger of the code coverage build had it pass this time. Its just so close to the limit that anything taking extra time can cause it to time out. We should take a look at it at some point and see if we can make it more stable. But everything has passed for now.

[ericstj]

If it's hovering close to the limit and we don't think there's a problem there we could always relax that limit. For now we can just 👀