OS X libomp CI fix. #5771
Merged
OS X libomp CI fix. #5771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5771 +/- ##
==========================================
- Coverage 68.38% 68.32% -0.07%
==========================================
Files 1131 1131
Lines 241019 241019
Branches 25024 25024
==========================================
- Hits 164822 164669 -153
- Misses 69714 69846 +132
- Partials 6483 6504 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
|
eerhardt
approved these changes
Apr 28, 2021
tarekgh
approved these changes
Apr 28, 2021
ericstj
reviewed
Apr 28, 2021
| @@ -56,3 +56,5 @@ $ brew update && brew install cmake https://raw.githubusercontent.com/dotnet/mac | |||
| ``` | |||
|
|
|||
| Please note that newer versions of Homebrew [don't allow installing directly from a URL](https://github.com/Homebrew/brew/issues/8791). If you run into this issue, you may need to download libomp.rb first and install it with the local file instead. | |||
|
|
|||
| Also, libomp version 7.0.0 doesn't have a cask for Big Sur. You can work around this by downloading the libomp.rb file and then calling `brew install libomp.rb --build-from-source --formula`. | |||
There was a problem hiding this comment.
Presumably people will already have cloned the repo, so they can use that file rather than download it. Maybe we could even move the install steps to a bash script that's checked in and just tell folks to invoke that? Maybe make the CI process do the same?
There was a problem hiding this comment.
This step is only needed for Big Sur, the other versions of the OS work fine, Do we know the percentage of mac users on Big Sur compared to older versions? If its the majority I think that would be worth looking into.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the CI issue with libomp.
The issue is that version 7 of libomp doesn't have a bottle for Big Sur. The build machines must have just upgraded to it. If I tell it to build from source it is able to successfully build version 7, and when the tests run they are able to find the intel mkl library as well as pass all the tests. Version 7 of libomp seems to be linked with intel mkl somehow and thats why we need to keep using version 7.0.0 for now.