Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup. #5770

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Minor cleanup. #5770

merged 1 commit into from
Apr 29, 2021

Conversation

eerhardt
Copy link
Member

  • Remove dead code in PredictionEngine.cs
  • Fix build warnings

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #5770 (f4e4081) into main (d8fe817) will increase coverage by 20.81%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #5770       +/-   ##
===========================================
+ Coverage   68.38%   89.20%   +20.81%     
===========================================
  Files        1131      231      -900     
  Lines      241019    49268   -191751     
  Branches    25024     2044    -22980     
===========================================
- Hits       164826    43950   -120876     
+ Misses      69707     4949    -64758     
+ Partials     6486      369     -6117     
Flag Coverage Δ
Debug 89.20% <ø> (+20.81%) ⬆️
production ?
test 89.20% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/Microsoft.ML.AutoML.Tests/AutoFitTests.cs 87.07% <0.00%> (-1.97%) ⬇️
...ransformInference/TransformPostTrainerInference.cs
src/Microsoft.ML.Data/Data/Conversion.cs
src/Microsoft.ML.FastTree/FastTreeRanking.cs
src/Microsoft.ML.EntryPoints/ImportTextData.cs
src/Microsoft.ML.FastTree/Training/ScoreTracker.cs
src/Microsoft.ML.Data/Transforms/NopTransform.cs
src/Microsoft.ML.Sweeper/Parameters.cs
...rc/Microsoft.ML.Ensemble/OutputCombiners/Median.cs
.../Evaluators/Metrics/BinaryClassificationMetrics.cs
... and 889 more

- Remove dead code in PredictionEngine.cs
- Fix build warnings
Copy link
Member

@michaelgsharp michaelgsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@eerhardt
Copy link
Member Author

I rebased on the latest in hopes that CI will pass now.

@eerhardt eerhardt merged commit ff0c347 into dotnet:main Apr 29, 2021
@eerhardt eerhardt deleted the RemoveDeadCode branch April 29, 2021 00:08
@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants