Ensure ONNX export is compatible with Windows RS5 #550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shauheen
reviewed
Jul 18, 2018
| @@ -719,7 +719,7 @@ protected override bool SaveAsOnnxCore(OnnxContext ctx, int iinfo, ColInfo info, | |||
| var node = ctx.CreateNode(opType, srcVariableName, dstVariableName, ctx.GetNodeName(opType)); | |||
| node.AddAttribute("classes_strings", terms.DenseValues()); | |||
| node.AddAttribute("default_int64", -1); | |||
| node.AddAttribute("default_string", DvText.Empty); | |||
| node.AddAttribute("default_string", " "); //Temporary fix, since DvText.Empty is not supported by Lotus because it is empty string. | |||
There was a problem hiding this comment.
Please improve the comment here for general audience. #Resolved
|
@TomFinley OS X release was failing for LR models because I had UseThreads set to true. Thanks for reviewing. |
wschin
approved these changes
Jul 19, 2018
| @@ -719,7 +719,10 @@ protected override bool SaveAsOnnxCore(OnnxContext ctx, int iinfo, ColInfo info, | |||
| var node = ctx.CreateNode(opType, srcVariableName, dstVariableName, ctx.GetNodeName(opType)); | |||
| node.AddAttribute("classes_strings", terms.DenseValues()); | |||
| node.AddAttribute("default_int64", -1); | |||
| node.AddAttribute("default_string", DvText.Empty); | |||
| //default_string needs to be an empty string but there is a BUG in Lotus that | |||
There was a problem hiding this comment.
What is Lotus? Do you mean runtime?
| node.AddAttribute("multi_class", true); | ||
| node.AddAttribute("coefficients", _weights.SelectMany(w => w.DenseValues())); | ||
| node.AddAttribute("intercepts", _biases); | ||
| node.AddAttribute("classlabels_strings", _labelNames); | ||
| node.AddAttribute("classlabels_ints", Enumerable.Range(0, _numClasses).Select(x => (long)x)); |
There was a problem hiding this comment.
LR doesn't output labels (e.g., "A" and "B") anymore?
eerhardt
pushed a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
* remove domain from onnx operators for non-ML types. * Make ONNX compatible with Windows RS5 and add more tests. * PR feedback. * PR feedback. * fix build.
codemzs
added a commit
to codemzs/machinelearning
that referenced
this pull request
Aug 1, 2018
* remove domain from onnx operators for non-ML types. * Make ONNX compatible with Windows RS5 and add more tests. * PR feedback. * PR feedback. * fix build.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #549 by testing ONNX models on Windows RS5 machine.