Changed default value of RowGroupColumnName from null to GroupId #5290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@justinormont This is the final pr needed to close the changing default issue. Per our discussion, I have updated the test that was missing the GroupId column to include that column. |
Codecov Report
@@ Coverage Diff @@
## master #5290 +/- ##
==========================================
- Coverage 73.49% 69.51% -3.99%
==========================================
Files 1014 779 -235
Lines 188680 145816 -42864
Branches 20330 18576 -1754
==========================================
- Hits 138677 101369 -37308
+ Misses 44493 39276 -5217
+ Partials 5510 5171 -339
|
Codecov Report
@@ Coverage Diff @@
## master #5290 +/- ##
==========================================
+ Coverage 73.49% 73.75% +0.25%
==========================================
Files 1014 1022 +8
Lines 188680 190340 +1660
Branches 20330 20471 +141
==========================================
+ Hits 138677 140384 +1707
+ Misses 44493 44440 -53
- Partials 5510 5516 +6
|
|
Could you please share what's the impact of this change? Does it lead to faster training or accurate result or anything else? #WontFix |
|
Hey Frank, issue #4749 talks more about it, but basically we want to have good default values so that the default experience for end users is good. If you do tree training without a group, it has bad results. By making the default use a group, then the default will be better results. In fact, only 1 of our tests didn't have a group, the rest did have a group for that reason. |
Codecov Report
@@ Coverage Diff @@
## master #5290 +/- ##
==========================================
+ Coverage 73.49% 73.75% +0.25%
==========================================
Files 1014 1022 +8
Lines 188680 190340 +1660
Branches 20330 20471 +141
==========================================
+ Hits 138677 140384 +1707
+ Misses 44493 44440 -53
- Partials 5510 5516 +6
|
Codecov Report
@@ Coverage Diff @@
## master #5290 +/- ##
==========================================
+ Coverage 73.49% 73.75% +0.25%
==========================================
Files 1014 1022 +8
Lines 188680 190340 +1660
Branches 20330 20471 +141
==========================================
+ Hits 138677 140388 +1711
+ Misses 44493 44439 -54
- Partials 5510 5513 +3
|
|
Thanks, got it In reply to: 655049589 [](ancestors = 655049589) |
| @@ -7675,7 +7675,7 @@ | |||
| "Required": false, | |||
| "SortOrder": 5.0, | |||
| "IsNullable": false, | |||
| "Default": null | |||
There was a problem hiding this comment.
Question: Just curious, was the manifest automatically updated simply by adding the constructor logic you added?
This was referenced Jul 10, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final pr to fix issue #4749, changes the default value of RowGroupColumnName from null to GroupId.