Added ONNX export support and tests for {FixedPlatt, Naive}CalibratorEstimators #5289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harishsk
reviewed
Jul 7, 2020
mstfbl
commented
Jul 8, 2020
mstfbl
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5289 +/- ##
========================================
Coverage 73.79% 73.80%
========================================
Files 1022 1022
Lines 190490 190617 +127
Branches 20484 20488 +4
========================================
+ Hits 140571 140677 +106
- Misses 44395 44418 +23
+ Partials 5524 5522 -2
|
harishsk
reviewed
Jul 10, 2020
harishsk
reviewed
Jul 10, 2020
Lynx1820
reviewed
Jul 10, 2020
harishsk
reviewed
Jul 11, 2020
harishsk
reviewed
Jul 11, 2020
| { | ||
| // Initialize variables needed for the ONNX conversion test | ||
| var (mlContext, dataView, estimators, initialPipeline) = GetEstimatorsForOnnxConversionTests(); | ||
|
|
There was a problem hiding this comment.
Sorry, you might have just introduced a bug here. The mlContext returned from GetEstimatorsForOnnxConversionTests is now different from the MLContext used to create the calibrator. Either you should fix GetEstimatorsForOnnxConversionTests to use the MLContext from the base class or pass it in as a param to this function like I mentioned in my earlier comment.
There was a problem hiding this comment.
Thank you for the heads up, I have removed the usage of MLContext in these tests in lieu of ML.
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial Fix for #5277
Added ONNX export support for the Naive calibrator estimator. FixedPlatt calibrator estimator can already be exported as it is deriving from Platt calibrator, which is also already supported.
Also added unit tests to check ONNX export for FixedPlatt and Naive calibrator estimators. Specifically, I have consolidated the separate unit tests of calibrators with/without standard date and binary prediction trainers into 1 unit test per calibrator.
ONNX export support for
IsotonicCalibratorEstimatorwill come in a separate PR.