Fixed score column name and order bugs in CalibratorTransformer #5261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5261 +/- ##
==========================================
+ Coverage 73.49% 73.74% +0.24%
==========================================
Files 1014 1022 +8
Lines 188680 190200 +1520
Branches 20330 20463 +133
==========================================
+ Hits 138677 140266 +1589
+ Misses 44493 44418 -75
- Partials 5510 5516 +6
|
mstfbl
commented
Jun 30, 2020
test/Microsoft.ML.Tests/TrainerEstimators/CalibratorEstimators.cs
Outdated
Show resolved
Hide resolved
antoniovs1029
approved these changes
Jul 1, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4700
As explained in #4700, the column order in which the Score column is given to
PlattCalibratorTransformerexposes a bug inCalibratorTransformerwhere the name and the location of the score column is hard-coded. This PR fixes this hard-coding, where now the name and order of the score column given toCalibratorTransformercan be different than the default values.I have also added unit tests to confirm these changes with respect to direct non-standard column name tests and Onnx Conversions.